Bug 166673 - gpg messages not showed
Summary: gpg messages not showed
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Jabber Plugin (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-15 22:59 UTC by Marek
Modified: 2009-03-27 03:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed patch for correct handling of encrypted messages (1.40 KB, patch)
2008-12-08 14:40 UTC, Jaroslav Reznik
Details
+MUC patch (3.65 KB, patch)
2008-12-09 14:48 UTC, Jaroslav Reznik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek 2008-07-15 22:59:51 UTC
Version:            (using Devel)
Installed from:    Compiled sources
OS:                Linux

Any gpg encrypted message is not received (nothing pops up, nothing to read). It seems that there is not gnupg plugin at all, but in this case at least a message with cipher text should appear. This is really pain, because you are not even noticed when anyone sends you a message
Comment 1 Jaroslav Reznik 2008-12-08 12:24:39 UTC
I can confirm this issue with encrypted messages. Problem occurred somewhere between 3.5 -> 4.0 release. Code handling encrypted messages has been reworked. It's not working even with kopete-cryptography plugin - it's not notified about new message.
I'm trying to prepare patch.
Comment 2 Jaroslav Reznik 2008-12-08 14:40:53 UTC
Created attachment 29144 [details]
Proposed patch for correct handling of encrypted messages

Patch checks if kopete-cryptography plugin is loaded + encrypted messages are no longer throw away and are correctly sent to kopete-cryptography plugin.
Comment 3 Jaroslav Reznik 2008-12-08 14:48:50 UTC
One remaining problem is with receiving encrypted message when no chat window is shown - Kopete crashes. When chat window is already shown, no problem. But I'm not sure about message flow in Kopete. Should I fill another bug?
Comment 4 Till Maas 2008-12-08 21:58:06 UTC
Similiar code is also located in these files, maybe they should be patched, too:

jabbergroupcontact.cpp
jabbergroupmembercontact.cpp
Comment 5 Jaroslav Reznik 2008-12-09 14:45:36 UTC
(In reply to comment #4)
> Similiar code is also located in these files, maybe they should be patched,
> too:
> 
> jabbergroupcontact.cpp
> jabbergroupmembercontact.cpp
> 

You are right - to solve this bug it's necessary to patch these two files too.
Comment 6 Jaroslav Reznik 2008-12-09 14:48:05 UTC
Created attachment 29176 [details]
+MUC patch
Comment 7 Matt Rogers 2009-03-27 03:52:58 UTC
This has been fixed in trunk for 4.3 and in the 4.2 branch for 4.2.3