Bug 165666 - link is opened twice when using ctrl + left_click to open a link in a tab
Summary: link is opened twice when using ctrl + left_click to open a link in a tab
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-03 22:22 UTC by Hanno
Modified: 2009-05-06 12:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Path to fix double-tab opening (1.96 KB, patch)
2009-05-05 14:55 UTC, Jonathan Marten 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno 2008-07-03 22:22:17 UTC 
Version:           1.2.50 (using 4.00.84 (KDE 4.0.84 (KDE 4.1 >= 20080625) "release 1.3", KDE:KDE4:Factory:Desktop / openSUSE_11.0)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.25.5-1.1-default

Reproduce:

Click on a link in order to open an article from a feed while pressing CTRL. This should open the link in a new tab in akregator, but it actually opens it twice.

No big deal, I know :-) but still annoying.
Comment 1 Frank Osterfeld 2008-10-28 22:47:50 UTC 
Confirmed.
Comment 2 Kari Argillander 2009-01-10 00:38:47 UTC 
I confirm this in version 1.3.3 with OpenSuse 11.1 and Kde 4.1.3 release 4.9
Comment 3 Hanno 2009-02-20 10:59:34 UTC 
still present in 4.2, qt4.5
Comment 4 Jonathan Marten 2009-05-05 14:55:22 UTC 
Created attachment 33367 [details]
Path to fix double-tab opening

This patch appears to fix the problem in current trunk.  See
http://websvn.kde.org/*checkout*/trunk/KDE/kdelibs/KDE4PORTING.html#kparts
for the cause, "The two createNewWindow signals have been merged into a single one".  So only one connect of this signal is needed, and the overload of
slotCreateNewWindow is not needed either.
Comment 5 Frank Osterfeld 2009-05-05 15:56:29 UTC 
Looks good, that signal gave a "this is a compat signal" style warning anyway I think. Please commit.
Comment 6 Jonathan Marten 2009-05-06 12:48:14 UTC 
SVN commit 964214 by marten:

Fix for *two* new tabs being opened when Ctrl-clicking on a link in the article
viewer.  There is now only one KParts::BrowserExtension::createNewWindow
signal, so no need to connect to it twice.

BUG:165666


 M  +0 -13     articleviewer.cpp  
 M  +0 -2      articleviewer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=964214