Version: (using KDE 3.5.8) Installed from: SuSE RPMs OS: Linux The image insertion dialog allows to embed the /includegraphics in a figure environment. However the floating type ( t,b,p,h ) of the figure environment has to be set manually. For convenience it would be nice to select the floating type of the image directly in the image insertion dialog. An additional improvement would be, if a previous selection of the floating type was set as the default selection for any following uses of the image insertion dialog.
Created attachment 24321 [details] patch adds float position and remembers settings for next image insertion
Hi, the patch looks good and it looks quite promising. Some small enhancements would be nice: - a box for setting the "!" flag would be nice - an additional KLineEdit would be nice for flags from external packages like "H" Thanks, Thomas
Hi Thomas, That wouldn't be a problem to implement. Regarding the second point, it might be nice if Kile could read in the /includepackage tags to offer extra options accordingly or/and offer options available from extra packages and add it to the package head with /includepackage if not present already. Examples for extra features in image insertion box: 1.option to wrap text around figure when \usepackage{wrapfig} is used. 2.allow multiple images in one figure environment with \subfloat when \usepackage{subfig} is used (http://en.wikibooks.org/wiki/LaTeX/Floats,_Figures_and_Captions) A sort of /includepackage-"manager" for could also be interesting for other features than image insertion, as eg amsmath features are offered in kile by default. But probably that should be part of a new "Bug"/wish-report. I know there is something similar to what I have in mind in the wizard (quickdocumentdialog) for making a new document. I will have to look closer into the code of that. I would prefer that "package-manager" to be available also when working with the document not only >before< making it. Kind Regards Dan
Hi Dan, the information about the included packages is already available in kile. E.g. insert a cyrillic letter and kile will tell you that you must include some more packages. But the idea of an package-manager sounds interesting. Please keep in mind that we already started porting kile to KDE4, and the KDE 3 port is in bugfixing mode only (officially). Bye, Thomas
Created attachment 24614 [details] patch includes positioning features of previous patch and "!" This patch allows htbp and ! to select in the dialogue. I have not yet implemented an alternative Textbox for user-defined positioning keys. However I have added a scale-box for setting the a scaling-factor, that proportionally (width&height) scales the image - at times that is more comfortable than setting the width and height directly.
Hello Daniel, your patch looks good. I would like to add it to kile trunk, which is based on KDE4. Are you a bit familiar with the QT-Designer? If yes, it would be nice if you could port your patch to the newly created ui file includegraphicsdialog_base.ui in src/dialogs. The implementation is in includegraphicsdialog.* Thanks, Thomas
Hi Thomas, That's nice to hear! Yes I have worked with that designer before. Only at the last time I checked out the trunk I couldn't it get working with KDE4 on my system. I'll have to look into it again ( I should do that anyway) and will do the changes on the ui file then. Regards Daniel
Any update here?
Created attachment 31500 [details] patch for KDE4
Patch for KDE4 with designer info above. This just addresses the position arguments, not scaling or arbitrary options. Would a line edit for additional options be superfluous? Why type latex markup into a config dialog instead of directly into the document?
Created attachment 31506 [details] KDE4 + extra options Provides additional options to the includegraphics dialog
Fixed by David Lonie in r929754.
SVN commit 930247 by dlonie: Added textwrapping options to the includegraphics dialog. CCBUG: 160806 GUI M +130 -25 dialogs/includegraphicsdialog.cpp M +3 -0 dialogs/includegraphicsdialog.h M +370 -186 dialogs/includegraphicsdialog_base.ui M +24 -0 kile.kcfg WebSVN link: http://websvn.kde.org/?view=rev&revision=930247