Bug 154904 - Amarok keeps playing current lastfm song when requested to skip (if next track is also lastfm)
Summary: Amarok keeps playing current lastfm song when requested to skip (if next trac...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Packages Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-31 16:09 UTC by Daniel Hahler
Modified: 2008-10-30 02:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hahler 2007-12-31 16:09:36 UTC
Version:           1.4.8 (using KDE KDE 3.5.8)
Installed from:    Ubuntu Packages

Reproduce:
1. Add a radio station to the playlist
2. Start playing
3. Add another station after it
4. Press the Amarok "Next Track" button

ACTUAL RESULT:
Amarok switches to the next station in the playlist, indicates that it plays it and says "connecting to stream resource" for a few seconds, but keeps playing the current/previous station!
Only when the currently playing song ends, Amarok starts playing the next station.

EXPECTED RESULT:
Amarok should stop playing the current station and play the next one instead.

This is not the case, if the next item in the tracklist is a "normal" song (e.g. from local media) or another playlist.
Only if the next track is also a lastfm radio station, it keeps playing the current song till the end.

This is with amarok 1.4.8-0ubuntu1 in Ubuntu Hardy.
Also reported in launchpad: https://launchpad.net/bugs/179556
Comment 1 Leo Franchi 2008-10-30 02:26:05 UTC
SVN commit 877693 by lfranchi:

new last.fm code for the last.fm service. basically, this replaces our old last.fm code drop from the 1.4 client with the  new modular liblastfm from max at last.fm. currently the library is included here in-source, and we are compiling it as a lib and linking to it internally. as soon as they can, last.fm will release it as liblastfm, and amarok will depend on it. for now, and 2.0, this will stay in-source. note that i include a FindLibLastFm.cmake that is not being used, as soon as we switch to the external lib we can just switch to searching for the external lib w/ no hassle.

NOTE: *please* test. i've tried to stress it as much as i can, but i can't think of all the edge cases. break it!

this should fix a number of bugs with the old client. there is 1 bug that i know of with this code, and i have email max.

BUG: 164156
BUG: 157296
BUG: 155197
BUG: 154904
BUG: 170816