Bug 154708 - Build and functionality fixes for ksysguardd on NetBSD
Summary: Build and functionality fixes for ksysguardd on NetBSD
Status: RESOLVED FIXED
Alias: None
Product: ksysguard
Classification: Unclassified
Component: ksysguardd (show other bugs)
Version: unspecified
Platform: NetBSD pkgsrc NetBSD
: NOR normal (vote)
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-27 21:16 UTC by Mark Davies
Modified: 2007-12-28 10:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
NetBSD patches for RC2 (26.96 KB, patch)
2007-12-27 21:18 UTC, Mark Davies
Details
NetBSD patches for 3.5 branch (19.60 KB, patch)
2007-12-27 21:19 UTC, Mark Davies
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Davies 2007-12-27 21:16:31 UTC
Version:            (using KDE KDE 3.97.0)
Installed from:    NetBSD pkgsrc
Compiler:          gcc4 
OS:                NetBSD

ksysguardd for NetBSD doesn't build in 4.0RC2 and doesn't build for some versions of NetBSD.  Also some of the Process/Memory/CPU values are not calculated correctly or appropriate for NetBSD.

I will attach patches that fix these issues for RC2 and also for the 3.5 branch.

cheers
mark
Comment 1 Mark Davies 2007-12-27 21:18:09 UTC
Created attachment 22708 [details]
NetBSD patches for RC2
Comment 2 Mark Davies 2007-12-27 21:19:07 UTC
Created attachment 22709 [details]
NetBSD patches for 3.5 branch
Comment 3 John Tapsell 2007-12-27 21:29:35 UTC
Mark,
  Thank you!

   Can you put these under LGPLv2 or later please?  It makes life a
bit easier :)
Comment 4 John Tapsell 2007-12-27 21:38:13 UTC
Presumably the bits of code like:

+#if defined(__DragonFly__)
and
+#if defined(__FreeBSD__) && __FreeBSD_version >= 500015

etc can be removed?
Comment 5 Mark Davies 2007-12-28 05:26:19 UTC
> Presumably the bits of code like: 
 
> +#if defined(__DragonFly__) 
> and 
> +#if defined(__FreeBSD__) && __FreeBSD_version >= 500015 
 
> etc can be removed? 
 
If you mean in processes_netbsd_p.cpp then yes.  That file was just copied from processes_freebsd_p.cpp and then very slightly tweaked to build.  I haven't actually looked at its contents too closely so it may well need some additional work to give reasonable values (beyond just building) but I was conscious of the approaching release -- whereas the rest of the patches have a longer history, deriving from the 3.5 branch versions.
Comment 6 Mark Davies 2007-12-28 05:29:11 UTC
>   Can you put these under LGPLv2 or later please?  It makes life a 
> bit easier :) 
 
They're just a few patches to existing files, but if it makes things easier then sure, what do I need to do?
Comment 7 John Tapsell 2007-12-28 10:35:56 UTC
> They're just a few patches to existing files, but if it makes things easier then sure,

Excellent.
> what do I need to do?

You've already done it :-)
Comment 8 John Tapsell 2007-12-28 10:42:41 UTC
SVN commit 753714 by johnflux:

Support for NetBSD, thanks to Mark Davies.

BUG:154708


 M  +6 -1      processes_local_p.h  
 A             processes_netbsd_p.cpp   [License: LGPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=753714