Bug 146541 - "use mouse navigation instead of scroll-bars" doesn't work any more
Summary: "use mouse navigation instead of scroll-bars" doesn't work any more
Status: RESOLVED INTENTIONAL
Alias: None
Product: kopete
Classification: Applications
Component: Contact list (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-08 15:05 UTC by Andreas Pietzowski
Modified: 2007-12-12 14:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Pietzowski 2007-06-08 15:05:44 UTC
Version:           0.12.5 (using KDE 3.5.7 "release 31.1" , openSUSE )
Compiler:          Target: i586-suse-linux
OS:                Linux (i686) release 2.6.18.8-0.1-default

Hello,

since the last SuSE-update the feature with "use mouse navigation instead of scroll-bars" doesn't work anymore. the srcollbars are always visible and no scrolling with mouse movement is done.

Thanks for fixing because I liked that behavior ;-)
Andreas
Comment 1 Matt Rogers 2007-06-09 08:06:59 UTC
probably broken by the commits to make kopete behave better with regard to timers and waking up the system too often.
Comment 2 Bruno Virlet 2007-08-29 11:16:47 UTC
SVN commit 706035 by bvirlet:

Remove the option because this was removed by the commits against 
smooth scrolling and this is not standard behavior.

https://bugzilla.novell.com/show_bug.cgi?id=304786
CCBUG: 146541



 M  +2 -7      kopete/config/behavior/behaviorconfig.cpp  
 M  +0 -15     kopete/config/behavior/behaviorconfig_general.ui  
 M  +2 -10     libkopete/kopeteprefs.cpp  
 M  +0 -3      libkopete/kopeteprefs.h  


--- branches/KDE/3.5/kdenetwork/kopete/kopete/config/behavior/behaviorconfig.cpp #706034:706035
@@ -89,10 +89,7 @@
 		this, SLOT(slotSettingsChanged(bool)));
 	connect(mPrfsGeneral->mAutoConnect, SIGNAL(toggled(bool)),
 		this, SLOT(slotSettingsChanged(bool)));
-	connect(mPrfsGeneral->mMouseNavigation, SIGNAL(toggled(bool)),
-		this, SLOT(slotSettingsChanged(bool)));
 
-
 	// "Events" TAB ============================================================
 	connect(mPrfsEvents->mQueueOnlyHighlightedMessagesInGroupChatsChk, SIGNAL(toggled(bool)),
 		this, SLOT(slotSettingsChanged(bool)));
@@ -171,7 +168,6 @@
 	p->setUseStack(mPrfsGeneral->mUseStackChk->isChecked());
 	p->setQueueUnreadMessages(mPrfsGeneral->mQueueUnreadMessagesChk->isChecked());
 	p->setAutoConnect(mPrfsGeneral->mAutoConnect->isChecked());
-	p->setContactListMouseNavigation(mPrfsGeneral->mMouseNavigation->isChecked());
 
 	// "Events" TAB ============================================================
 	p->setQueueOnlyHighlightedMessagesInGroupChats(mPrfsEvents->mQueueOnlyHighlightedMessagesInGroupChatsChk->isChecked());
@@ -197,7 +193,7 @@
 	config->writeEntry("UseAutoAway", mAwayConfigUI->mUseAutoAway->isChecked() );
 	config->writeEntry("UseAutoAwayMessage", mAwayConfigUI->mDisplayCustomAwayMessage->isChecked() );
 	config->sync();
-	
+
 	// Save the auto away message, if defined
 	if( mAwayConfigUI->mDisplayCustomAwayMessage->isChecked() )
 	{
@@ -210,7 +206,7 @@
 	p->setSpellCheck(mPrfsChat->cb_SpellCheckChk->isChecked());
 	p->setInterfacePreference( viewPlugins[mPrfsChat->viewPlugin->currentItem()]->pluginName() );
 	p->setChatWindowPolicy(mPrfsChat->cmbChatGroupingPolicy->currentItem());
-	
+
 	p->setChatViewBufferSize(mPrfsChat->mChatViewBufferSize->value());
 	p->setTruncateContactNames(mPrfsChat->truncateContactNameEnabled->isChecked());
 	p->setMaxContactNameLength(mPrfsChat->mMaxContactNameLength->value());
@@ -234,7 +230,6 @@
 	mPrfsGeneral->mUseStackChk->setChecked( p->useStack() );
 	mPrfsGeneral->mQueueUnreadMessagesChk->setChecked ( p->queueUnreadMessages() );
 	mPrfsGeneral->mAutoConnect->setChecked( p->autoConnect() );
-	mPrfsGeneral->mMouseNavigation->setChecked( p->contactListMouseNavigation() );
 
 	// "Events" TAB ============================================================
 	mPrfsEvents->mQueueOnlyHighlightedMessagesInGroupChatsChk->setChecked ( p->queueOnlyHighlightedMessagesInGroupChats() );
--- branches/KDE/3.5/kdenetwork/kopete/kopete/config/behavior/behaviorconfig_general.ui #706034:706035
@@ -160,20 +160,6 @@
                         <string>When starting Kopete all your accounts will be connected automatically. Note: You can exclude accounts individually in their properties.</string>
                     </property>
                 </widget>
-                <widget class="QCheckBox">
-                    <property name="name">
-                        <cstring>mMouseNavigation</cstring>
-                    </property>
-                    <property name="text">
-                        <string>Use mouse &amp;navigation instead of scroll-bars</string>
-                    </property>
-                    <property name="toolTip" stdset="0">
-                        <string>Use mouse navigation instead of scroll-bars for contact list</string>
-                    </property>
-                    <property name="whatsThis" stdset="0">
-                        <string>This navigation scheme is designed to remove the vertical scrollbar. Instead of dragging the scrollbar you just move your mouse on the list vertically: as you move your mouse, the list will move in the opposite direction and you can reach your target contact. Each contact will be under the mouse cursor at a certain point.</string>
-                    </property>
-                </widget>
             </vbox>
         </widget>
         <spacer>
@@ -220,7 +206,6 @@
     <tabstop>mStartDockedChk</tabstop>
     <tabstop>mUseQueueChk</tabstop>
     <tabstop>mAutoConnect</tabstop>
-    <tabstop>mMouseNavigation</tabstop>
 </tabstops>
 <layoutdefaults spacing="6" margin="11"/>
 </UI>
--- branches/KDE/3.5/kdenetwork/kopete/libkopete/kopeteprefs.cpp #706034:706035
@@ -147,7 +147,6 @@
 	mContactListAnimation = config->readBoolEntry("AnimateChanges", true);
 	mContactListFading = config->readBoolEntry("FadeItems", true);
 	mContactListFolding = config->readBoolEntry("FoldItems", true);
-	mContactListMouseNavigation = config->readBoolEntry("MouseNavigation", false );
 	mContactListAutoHide = config->readBoolEntry("AutoHide", false);
 	mContactListAutoHideTimeout = config->readUnsignedNumEntry("AutoHideTimeout", 30);
 
@@ -239,7 +238,6 @@
 	config->writeEntry("AnimateChanges", mContactListAnimation);
 	config->writeEntry("FadeItems", mContactListFading);
 	config->writeEntry("FoldItems", mContactListFolding);
-	config->writeEntry("MouseNavigation", mContactListMouseNavigation );
 	config->writeEntry("AutoHide", mContactListAutoHide);
 	config->writeEntry("AutoHideTimeout", mContactListAutoHideTimeout);
 
@@ -401,7 +399,7 @@
 	mBalloonNotifyIgnoreClosesChatView = value;
 }
 
-void KopetePrefs::setBalloonClose( bool value ) 
+void KopetePrefs::setBalloonClose( bool value )
 {
 	mBalloonClose = value;
 }
@@ -425,7 +423,7 @@
 void KopetePrefs::_setStylePath(const QString &stylePath)
 {
 	mStylePath = stylePath;
-	
+
 	// Fallback to default style if the directory doesn't exist
 	// or the value is empty.
 	if( !QFile::exists(stylePath) || stylePath.isEmpty() )
@@ -634,12 +632,6 @@
 	mContactListFolding = n;
 }
 
-void KopetePrefs::setContactListMouseNavigation( bool n )
-{
-	if( n != mContactListMouseNavigation ) mContactListAppearanceChanged = true;
-	mContactListMouseNavigation = n;
-}
-
 void KopetePrefs::setContactListAutoHide( bool n )
 {
 	if( n != mContactListAutoHide ) mContactListAppearanceChanged = true;
--- branches/KDE/3.5/kdenetwork/kopete/libkopete/kopeteprefs.h #706034:706035
@@ -122,7 +122,6 @@
 	bool contactListAnimation() const { return mContactListAnimation; }
 	bool contactListFading() const { return mContactListFading; }
 	bool contactListFolding() const { return mContactListFolding; }
-	bool contactListMouseNavigation() const { return mContactListMouseNavigation; }
 	bool contactListAutoHide() const { return mContactListAutoHide; }
 	unsigned int contactListAutoHideTimeout() const { return mContactListAutoHideTimeout; }
 
@@ -186,7 +185,6 @@
 	void setContactListAnimation( bool );
 	void setContactListFading( bool );
 	void setContactListFolding( bool );
-	void setContactListMouseNavigation( bool );
 	void setContactListAutoHide( bool );
 	void setContactListAutoHideTimeout( unsigned int );
 	void setReconnectOnDisconnect( bool newSetting );
@@ -306,7 +304,6 @@
 	bool mContactListAnimation;
 	bool mContactListFading;
 	bool mContactListFolding;
-	bool mContactListMouseNavigation;
 	bool mContactListAutoHide;
 	unsigned int mContactListAutoHideTimeout;
 
Comment 3 Bruno Virlet 2007-08-29 11:19:21 UTC
See previous comment.
Comment 4 Matt Blissett 2007-12-10 00:29:35 UTC
Is this gone for good?  If so, why?  It was really useful, I'm missing the feature already!
Comment 5 Will Stephenson 2007-12-12 14:06:56 UTC
It's gone for KDE 3 and I expect also for KDE 4.  I see no reason why Kopete needs an extra way to navigate when every other list view in kde gets by with keyboard, mouse wheel and scrollbars.