Bug 144733 - kamera ioslave is very slow (redundant calls!?) [patch]
Summary: kamera ioslave is very slow (redundant calls!?) [patch]
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: kamera (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Marcus Meissner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-27 02:01 UTC by Daniel Hahler
Modified: 2009-08-01 20:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
The patch mentioned above. Taken from http://lists.kde.org/?l=kde-devel&m=112637748006798&w=2 (3.15 KB, patch)
2007-04-27 02:02 UTC, Daniel Hahler
Details
kio_kamera.pat (10.51 KB, patch)
2007-05-16 07:28 UTC, Marcus Meissner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Hahler 2007-04-27 02:01:19 UTC
Version:            (using KDE KDE 3.5.6)
Installed from:    Ubuntu Packages

The "meta part" of the camera:// ioslave is very slow - not the copying itself, but initialising the camera.

E.g., when copying a list of files from one Konqueror window to another, the collecting of the files alone takes far too long (like after some minutes it knows that 4 files should get copied)

There has been a patch posted at kde-devel (http://lists.kde.org/?l=kde-devel&m=112637748006798&w=2) and I can confirm that it fixes the slowliness: it does not take ages to "count" the number of files anymore - the copy process starts directly.

(What is still quite slow is changing directories, but that is probably some other, not related issue.)

Patch: http://lists.kde.org/?l=kde-devel&m=112637748006798&w=2
Launchpad/Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/kdegraphics/+bug/62629
Comment 1 Daniel Hahler 2007-04-27 02:02:50 UTC
Created attachment 20390 [details]
The patch mentioned above. Taken from http://lists.kde.org/?l=kde-devel&m=112637748006798&w=2

The patch as Szombathelyi "György" has sent it to kde-devel.
Comment 2 Marcus Meissner 2007-04-27 07:40:17 UTC
and did you try it?

the problem is still that multiple IO slaves get started, so we have to close the camera at some point.
Comment 3 Marcus Meissner 2007-04-27 07:44:06 UTC
The underlying problem is really that we close and open the camera for every request due to the multiple ioslaves problem.

If we just could tell the trader that we only want 1 slave ... but this was not possible last time I checked.
Comment 4 Marcus Meissner 2007-05-16 07:27:40 UTC
I have now changed the slave to be faster.

Due to problem of the multiple slaves it is not an optimal solution, but for common access patterns it will be faster now.
Comment 5 Marcus Meissner 2007-05-16 07:28:12 UTC
Created attachment 20581 [details]
kio_kamera.pat

patch I committed to 3_5 BRANCH
Comment 6 Marcus Meissner 2007-05-16 07:28:27 UTC
still have to port it to TRUNK.
Comment 7 Marcus Meissner 2007-05-16 14:58:54 UTC
also committed to TRUNK (kde4)
Comment 8 Daniel Hahler 2007-05-28 17:05:59 UTC
Thanks for attacking this problem!

But I think this bug is not really resolved yet.

E.g., I'm just deleting 45 files on my camera.
The progress window says "Initialising camera" for a short period, then "Deleting file" for ~ 3-5 seconds and then "Stalled" for 10-30 seconds.
This gets done for every file and the most time here gets spent in "Stalled" state.

Additionally, it first collects info about the total number of files, which also took quite long!

In total, deleting 45 files takes more than half an hour!

(I'm using Ubuntu Feisty with KDE 3.5.7 from kubuntu.org)
Comment 9 Marcus Meissner 2007-05-29 00:38:06 UTC
what camera are you using? and what libgphoto2 version?
Comment 10 Daniel Hahler 2007-05-29 02:14:21 UTC
libgphoto2-2 2.3.0-0ubuntu4 and a FujiFilm F30 camera.
Comment 11 Daniel Hahler 2009-08-01 20:53:09 UTC
This appears to be fixed (tested in 4.2.98).