Bug 142260 - Tab bar looks ugly if konsole part is not translucent
Summary: Tab bar looks ugly if konsole part is not translucent
Status: RESOLVED FIXED
Alias: None
Product: yakuake
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Packages Linux
: NOR wishlist with 2 votes (vote)
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-27 11:58 UTC by Alberto Manzaneque
Modified: 2007-10-06 21:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Manzaneque 2007-02-27 11:58:47 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages
OS:                Linux

I really like yakuake but I don't like to use a translucent konsole, so yakuake tab bar looks really ugly because it has no option for disabling (fake) transparency.

I have tried to write some code to detect at run time the colour that the konsole part is using , but I guess the kpart interface doesn't allow us to do that. So I think there are 3 ways to get a better looking tab bar in yakuake:
- Implement an option to enable/disable tab bar tranparency.
- Take out transparency and always draw the tab bar with the user's desktop colours.
- Implement a standard KTabBar (like konsole does) instead of the custom bar.


PD: Sorry for my poor english, I hope you understand me.
Comment 1 Eike Hein 2007-02-27 12:17:35 UTC
There's a fourth way, which will be implemented: Ship a skin that doesn't use translucent pixmaps.

Yakuake already has the capability to load different skins, and in an upcoming release that will be made more accessible by the new configuration dialog offering a skin chooser tab. I plan on bundling a non-translucent variant of the default skin and the popular Plastik skin from KDE-Look, maybe others as well.
Comment 2 Eike Hein 2007-10-06 21:52:10 UTC
SVN commit 722171 by hein:

Improved experience for non-KDE users by disabling KRootPixmap-based
pseudo-translucency for them. Gets rid of rendering errors with skins
that make use of the alpha channel. Replaced by configurable skin back-
ground color.
BUG:142260


 M  +4 -0      ChangeLog  
 M  +1 -1      src/Makefile.am  
 M  +11 -30    src/image_button.cpp  
 M  +5 -13     src/image_button.h  
 M  +47 -37    src/main_window.cpp  
 M  +1 -0      src/main_window.h  
 M  +13 -1     src/skin_settings.cpp  
 M  +1 -1      src/skin_settings.h  
 M  +80 -25    src/skin_settings_ui.ui  
 M  +10 -19    src/tab_bar.cpp  
 M  +4 -10     src/tab_bar.h  
 M  +13 -13    src/tabbed_widget.cpp  
 M  +4 -10     src/tabbed_widget.h  
 M  +3 -3      src/title_bar.cpp  
 A             src/translucent_widget.cpp   [License: GPL (v2+)]
 A             src/translucent_widget.h   [License: GPL (v2+)]
 M  +10 -0     src/yakuake.kcfg  


WebSVN link: http://websvn.kde.org/?view=rev&revision=722171