Bug 134919 - Gwenview 1.4.0 doesn't build with --enable-final
Summary: Gwenview 1.4.0 doesn't build with --enable-final
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-30 19:47 UTC by Christopher Martin
Modified: 2012-10-19 13:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Martin 2006-09-30 19:47:05 UTC
Version:           1.4.0 (using KDE KDE 3.5.4)
Installed from:    Debian testing/unstable Packages
Compiler:          GCC 4.1 
OS:                Linux

It would be a nice optimization for Gwenview to build with the --enable-final, like most of the rest of KDE. Currently, however the build fails.

(This would be a nice little extra, but it's obviously a wishlist item.)

 g++ -DHAVE_CONFIG_H -I. "-I/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore" -I../.. "-I/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/.." -I/usr/include/kde -I/usr/share/qt3/include -I. -D_LARGEFILE64_SOURCE -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -c libgwenviewcore_la.all_cpp.cpp  -fPIC -DPIC -o .libs/libgwenviewcore_la.all_cpp.o
In file included from /usr/include/png.h:363,
                 from /home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/pngformattype.cpp:43,
                 from libgwenviewcore_la.all_cpp.cpp:23:
/usr/include/pngconf.h:312:10: error: #error png.h already includes setjmp.h with some additional fixup.
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/imagesavedialog.cpp: In constructor 'Gwenview::ImageSaveDialog::ImageSaveDialog(KURL&, const QCString&, QWidget*)':
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/imagesavedialog.cpp:56: warning: 'setFilterMimeType' is deprecated (declared at /usr/include/kde/kfiledialog.h:313)
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/qxcfi.cpp: In static member function 'static bool Gwenview::XCFImageFormat::loadProperty(Gwenview::SafeDataStream&, PropType&, QByteArray&)':
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/qxcfi.cpp:1432: warning: 'data' may be used uninitialized in this function
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/qxcfi.cpp: In static member function 'static bool Gwenview::XCFImageFormat::loadMask(Gwenview::SafeDataStream&, Gwenview::XCFImageFormat::Layer&)':
/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/./src/gvcore/qxcfi.cpp:1179: warning: 'name' may be used uninitialized in this function
make[4]: *** [libgwenviewcore_la.all_cpp.lo] Error 1
make[4]: Leaving directory `/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/obj-i486-linux-gnu/src/gvcore'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/obj-i486-linux-gnu/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/obj-i486-linux-gnu'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/chris/gwenview-foo/gwenview-1.4.0~debian.1/obj-i486-linux-gnu'
make: *** [debian/stamp-makefile-build] Error 2
Comment 1 Aurelien Gateau 2006-11-03 16:04:21 UTC
SVN commit 601535 by gateau:

Fix build with --enable-final
BUG: 134919


 M  +1 -0      NEWS  
 M  +3 -1      gvcore/Makefile.am  


--- trunk/extragear/graphics/gwenview/NEWS #601534:601535
@@ -17,6 +17,7 @@
  - Fix content of KPart context menu when viewing remote images.
  - Do not let the KPart title get overriden when switching tabs.
  - Make context menu behavior coherent with KDE (Bug 136449).
+ - Fix compilation with --enable-final (Bug 134919).
 
 2006.09.16 - v1.4.0
 - Fixes:
--- trunk/extragear/graphics/gwenview/gvcore/Makefile.am #601534:601535
@@ -14,7 +14,10 @@
 
 noinst_HEADERS = libgwenview_export.h
 
+# Be sure to keep pngformattype.cpp first, to avoid troubles with --enable-final
+# See bug #134919
 libgwenviewcore_la_SOURCES = \
+	pngformattype.cpp \
 	printdialog.cpp \
 	printdialogpagebase.ui \
 	thumbnailloadjob.cpp \
@@ -39,7 +42,6 @@
 	filedetailviewitem.cpp \
 	imagesavedialog.cpp \
 	jpegformattype.cpp \
-	pngformattype.cpp \
 	mngformattype.cpp \
 	xpm.cpp \
 	documentimpl.cpp \