Bug 131915 - "Mark Message as Not To-Do" nonsensical; should be "Remove To-Do Mark" or similar
Summary: "Mark Message as Not To-Do" nonsensical; should be "Remove To-Do Mark" or sim...
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: general (show other bugs)
Version: 1.9.1
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-05 13:01 UTC by Mark Florian
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Florian 2006-08-05 13:01:59 UTC
Version:           1.9.1 (using KDE KDE 3.5.2)
Installed from:    Ubuntu Packages
OS:                Linux

If a message is marked as To-Do via "Mark Message as To-Do", the option to remove the flag is called "Mark Message as Not To-Do", which doesn't make sense and is inconsistent with the language used for the Important mark.

The Important flag has the options "Mark Message as Important" and "Remove Important Message Mark". Therefore the option to remove the To-Do flag should be named "Remove To-Do mark" or similar.
Comment 1 Allen Winter 2006-08-08 17:41:07 UTC
SVN commit 571133 by winterz:

New GUI Strings for KDE 3.5.5.
"Mark as Not To-do" becomes  "Remove To-do Mark"
"Mark as Not Sent" becomes "Remove Sent Mark"

BUG: 131915
GUI:


 M  +5 -5      kmmainwidget.cpp  


--- branches/KDE/3.5/kdepim/kmail/kmmainwidget.cpp #571132:571133
@@ -2572,13 +2572,13 @@
   mToggleTodoAction = new KToggleAction(i18n("Mark Message as &To-do"), "mail_todo",
                                  0, this, SLOT(slotSetMsgStatusTodo()),
                                  actionCollection(), "status_todo");
-  mToggleTodoAction->setCheckedState( i18n("Mark Message as Not &To-do") );
+  mToggleTodoAction->setCheckedState( i18n("Remove &To-do Message Mark") );
   mStatusMenu->insert( mToggleTodoAction );
 
   mToggleSentAction = new KToggleAction(i18n("Mark Message as &Sent"), "kmmsgsent",
                                  0, this, SLOT(slotSetMsgStatusSent()),
                                  actionCollection(), "status_sent");
-  mToggleSentAction->setCheckedState( i18n("Mark Message as Not &Sent") );
+  mToggleSentAction->setCheckedState( i18n("Remove &Sent Mark") );
 
 
   //----- "Mark Thread" submenu
@@ -2615,7 +2615,7 @@
   mToggleThreadTodoAction = new KToggleAction(i18n("Mark Thread as &To-do"), "mail_todo",
                                        0, this, SLOT(slotSetThreadStatusTodo()),
                                        actionCollection(), "thread_todo");
-  mToggleThreadTodoAction->setCheckedState( i18n("Mark Thread as Not &To-do") );
+  mToggleThreadTodoAction->setCheckedState( i18n("Remove &To-do Thread Mark") );
   mThreadStatusMenu->insert( mToggleThreadTodoAction );
 
   //------- "Watch and ignore thread" actions
@@ -2876,7 +2876,7 @@
 void KMMainWidget::slotShowMsgSrc()
 {
   if ( mMsgView )
-    mMsgView->setUpdateAttachment( false );  
+    mMsgView->setUpdateAttachment( false );
   KMMessage *msg = mHeaders->currentMsg();
   if ( !msg )
     return;
@@ -3014,7 +3014,7 @@
 
     mSendAgainAction->setEnabled( single_actions &&
              ( mHeaders->currentMsg() && mHeaders->currentMsg()->isSent() )
-          || ( mFolder && mHeaders->currentMsg() && 
+          || ( mFolder && mHeaders->currentMsg() &&
               ( kmkernel->folderIsDraftOrOutbox( mFolder )
              || kmkernel->folderIsSentMailFolder( mFolder ) ) ) );
     mSaveAsAction->setEnabled( mass_actions );