Bug 130093 - Progam freeze importing java classes
Summary: Progam freeze importing java classes
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Slackware Linux
: NOR crash (vote)
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-01 10:35 UTC by Manuel Reinaldo
Modified: 2006-07-01 23:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Reinaldo 2006-07-01 10:35:57 UTC
Version:           1.5.3 + (#129107) +(#126560, #129252) Build kdesdk-555673 (using KDE KDE 3.5.3)
Installed from:    Slackware Packages
Compiler:          gcc (GCC) 3.3.6 
OS:                Linux

The program freezes completelly when importing the following java class:

import java.awt.*;
import java.io.*;
import java.net.*;
import java.awt.event.*;
import javax.swing.*;
import java.awt.Toolkit;

public class DumpDownLoad
{
  

  JFrame frame=new JFrame();

  // Add the scroll panes to a split pane.
  JSplitPane vertical1 = new JSplitPane(JSplitPane.VERTICAL_SPLIT);

  // Create obects
  GridBagLayout layout = new GridBagLayout();
  JLabel versionLabel = new JLabel(new String(" Version to download: "));
  JLabel displayLabel = new JLabel(new String(""));
  JPanel topPanel = new JPanel(layout);
  JEditorPane logPane = new JEditorPane();
  JScrollPane bottomPane = new JScrollPane(logPane);
  JTextField versionText = new JTextField("",4); 

  
}
Comment 1 Oliver Kellogg 2006-07-01 23:54:47 UTC
SVN commit 556909 by okellogg:

skipToClosing(): Add check for QString::null return value from advance().
BUG:130093


 M  +1 -1      ChangeLog  
 M  +2 -0      umbrello/javaimport.cpp  


--- branches/KDE/3.5/kdesdk/umbrello/ChangeLog #556908:556909
@@ -1,7 +1,7 @@
 Version 1.5.4
 
 * Bugs/wishes from http://bugs.kde.org:
-* Fix crash when importing classes from a java file (129107)
+* Fix crash when importing classes from a java file (129107, 130093)
 * Crash after single click on the "UML Model" tree window (126560/129252)
 
 Version 1.5.3
--- branches/KDE/3.5/kdesdk/umbrello/umbrello/javaimport.cpp #556908:556909
@@ -111,6 +111,8 @@
     int nesting = 0;
     while (m_srcIndex < srcLength) {
         QString nextToken = advance();
+        if (nextToken.isEmpty())
+            break;
         if (nextToken == closing) {
             if (nesting <= 0)
                 break;