| Summary: | Visualizations only work if I start amarok with amarokapp | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Alexandre Oliveira <aoliveira> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mich |
| Priority: | NOR | ||
| Version: | 1.2-CVS | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
Alexandre Oliveira
2005-02-17 18:48:06 UTC
Same behaviour here, although I don't get any error messages when I run as "amarok". Using Gentoo too. Amarok, libvisual and etc. compiled for amd64 with GCC 3.4.3, KDE 3.4 beta 2. Forgot to mention, using amarok 1.2 I'm having the same problem under Debian (kernel 2.6.7). Starting amarokapp indeed solves the problem. amaroK 1.2 release (not CVS), libvisual 0.2.0, GCC 3.3.5, KDE 3.2.3 Fixed in CVS This problem has reappeared - problem has been confirmed on FreeBSD and arklinux. amarok: [SocketServer] true amarok: [SocketServer] false amarok: [SocketServer] Starting visualization.. amarok: [SocketServer] Connection requested: 29 amarok: [SocketServer] Registration pid: 23958 amarok: [SocketServer] false amarok: [SocketServer] recv() error, closing socket: 29 amarok: [SocketServer] Stopping visualization Reopen as requested by user Michael Landin Hostbaek, what version are you using? I'm using KDE-3.4.2 on FreeBSD (7.0-CURRENT) with amaroK 1.3.3 Michael, this bug was workarounded, I could never understand it very well, actually (it was my second or third patch for amaroK). After some tests I found out that when amaroK was started as "amarok", the visualization would crash right after trying to print stuff to stdout. It wouldn't happen if amaroK had been started as "amarokapp". I tried using KProcess functions to handle the output of the visualization program, and it solved this problem for me and other people. I can't reproduce this anymore, and can't test with FreeBSD, so I'll have to leave this for other person to fix this time. Thanks, for your quick reply. Actually I got a couple of people on #amarok (on Efnet) to reproduce this problem on their Linux distros (on of them being ArkLinux) as well. I do not believe this is a FreeBSD specific problem. i'm having this same behaviour with amarok 1.3.4 svn 14/10/2005 slackware 10.2 libvisual 0.2.0 gcc 3.3.6 kde 3.5 beta 1 if i run amarok with "amarok" i can't see the libvisual animations: libvisual WARNING: amarok_libvisual: visual_plugin_get_list(): Failed to add the /usr/lib/libvisual/transform directory to the plugin registry i can see them if in run amarok via amarokapp SVN commit 471162 by aoliveira: We regressed the bizarre "visualizations only work when ran as amarokapp" bug, due to a mistake on the code that closes the fds. BUG: 99627 M +3 -2 socketserver.cpp --- trunk/extragear/multimedia/amarok/src/socketserver.cpp #471161:471162 @@ -40,15 +40,16 @@ // class AmaroKProcess //////////////////////////////////////////////////////////////////////////////// /** Due to xine-lib, we have to make KProcess close all fds, otherwise we get "device is busy" messages - * Used by AmaroKProcIO and AmaroKProcess, exploiting commSetupDoneC(), a virtual method that + * Used by AmaroKProcIO and AmaroKProcess, exploiting commSetupDoneC(), a virtual method that * happens to be called in the forked process * See bug #103750 for more information. */ class AmaroKProcess : public KProcess { public: virtual int commSetupDoneC() { + int i = KProcess::commSetupDoneC(); amaroK::closeOpenFiles(KProcess::out[0],KProcess::in[0], KProcess::err[0]); - return KProcess::commSetupDoneC(); + return i; }; }; Great. It works for me now. Thanks for chasing this. |