Bug 99352

Created attachment 9614 [details]
Example of a pdf file that is displayed with wrong orientation

*** Bug 99311 has been marked as a duplicate of this bug. ***

Obviously this is a wish and not a bug, we display the document as it says it should be, if the document gives use incorrect information there is nothing we can do about it except provide the rotation option.

Already on TODO list. We can hack it on screen.. but for printing it will be hard.

I can confirm that this would be an important feature for KPDF.
A few days ago, I switched the konfiguration to use KPDF nstead of KGhostview. The interface and page display is so much better now. ;)

but I get PDFs from my fax software and that cannot determine if the page should be portrait or landscape, it's just an image. So It would be very helpful to be able to rotate the page.

IMHO, rotation should be just a screen thing, if you print the page, you can rotate it manually. ;-)

Giving 20 votes for this missing feature!

*** Bug 102514 has been marked as a duplicate of this bug. ***

I agree too. It's an important feature (IMO), but as far as printing, it's not biggie. It's visually that it's important. So I'm giving 20 votes as well :)

I also gave this a full 20 votes.  Recently I've had several courses offer the slides in PDF with no orientation flag (or however kpdf determines orientation).  So those landscape ones are a real pain to read.  I have to go back to kghostview.  But I like kpdf sooo much better!  Printing is a non-issue.  This is for the screen, only.

*** Bug 106948 has been marked as a duplicate of this bug. ***

i want to add myself to this whishlist ... lately i had trouble rotating single pages to see them better on the screen. an example document is here:

http://www.genome.org/cgi/reprint/13/4/533.pdf
pages 5 and 6 are much better seen landscape but the rest is portrait

printing is no trouble as it is now. it can stay the way it is handled now. 

to be more specific: like there is a button for "fit width", there should be also a button in the right-click menu for "rotate to left" and "rotate to right" for the current page. 

20 votes - thanx in advance

Printing isn't an issue, because these documents are supposed to be landscaped. They will print as intended, but they don't display as intended.

A hack for on-screen display before a solution for rotation in print is implemented would be quite worth-while IMHO.

Adding self to CC. Another sample is:
ftp://ftp.trolltech.com/qt/pdf/qt33-class-chart.pdf

As there seems to be a patch for this bug, should the patch be attached to this bugreport? Even if the patch will not be integrated in KDE 3.5.3 at least the patch will be found by users and distributors.

Created attachment 15196 [details]
first version

This is the first version to implement rotation.
It still has rough edges, but works in principle.
The things still open:
- after rotation, the thumbnails (pixmap) still show the content in the
original non-rotated form
- the very first pixmap you see in the page (the one with the roughest
granularity of pixels) shows the original non-rotated form.
- Highlighting of found text matches is shown incorrectly (uses the non-rotated
view)

I will support this wish with 20 votes. 

It is vital to be able to rotate pages when you are viewing train and bus timetables. Please implement rotation for 90/180/270 degrees!

Printing at rotated angles is not a priority right now, but being able to view at a rotated aspect _is_.

Another badly displayed pdf:
http://www.cs.washington.edu/education/courses/csep590/06wi/lectures/slides/Benaloh_010306.pdf

What is the status of this bug? It would be extremely usefull to at least be able to rotate the page 90 degreesn in presentation mode. Personally I often rotate my screen (physically) for reading documents to maximize the useage of the screen area. This obviously only works if the document can be rotated as well.
Are anyone working on this? If not I could have a go at it, but my KDE development experience is rather limited (non-existent).

On Friday 13 October 2006 20:11, Tom E.Gundersen wrote:
> What is the status of this bug? It would be extremely usefull to at least
> be able to rotate the page 90 degreesn in presentation mode.


The patch I provided does rotation.
See for the limitations it has:
http://bugs.kde.org/show_bug.cgi?id=99352#c15

This work on okular that is KDE4 successor of kpdf.

http://bugs.kde.org/show_bug.cgi?id=99352#c18
meanwhile you can use xpdf or acrobat reader. 

Regarding the patch provided (Additional Comment #15 From Martin Koller 2006-03-19 14:25):

Thank you for providing this patch - it works very well in general. 

However please note the rotation function in this patch will fail to operate correctly in some situations where pdf documents have inbuilt rotation values. This is one possible source fix (tested);

1. in sourcedir/core/page.cpp, add this text;

	void KPDFPage::rotate90degrees()
	{
	    float w = m_width;
	    m_width = m_height;
	    m_height = w;

	    // avoid Division-By-Zero problems in the program

	    if ( m_width <= 0 )
		m_width = 1;
	    if ( m_height <= 0 )
		m_height = 1;

	    deletePixmapsAndRects();
	}

2. in sourcedir/kpdf/core/page.h, class KPDFPage, public:, add this text;

	void rotate90degrees();
	
3. in sourcedir/kpdf/ui/pageview.cpp, void PageView::slotRotateLeft and slotRotateRight(), change this text;

	const_cast<KPDFPage*>((*iIt)->page())->setRotation( r );

		to;
	
	const_cast<KPDFPage*>((*iIt)->page())->rotate90degrees();

 

Will this patch go in Kpdf on the 3.5.x branch?

Quote from a mail on kde-core on June, 1st 2007:

The Release Team has decided that it is time to close the books on KDE 3.5.

To quote coolo:
"No more features, no more string changes, no more docu changes....
Bug fixes are allowed and after some time we'll do another maintenance 
update 3.5.8 - e.g. in september."

So bugfixes only from now on in the 3.5 branch.  If the bugfix requires
a string change, you will need to coordinate that change with the translators.

Onwards to KDE 4.0!

So, now you can change orientation of pdf files in okular, wouldn't it be sensible to close this bug?

Theorically no, as 'kpdf' and 'okular' are separate products on bugzilla.
If it would be closed, its resolution is WONTFIX (as we won't implement it) or INVALID (as the product will no more be "valid").

But for now don't worry about that.

Okay, close it. Nobody's going to do it. Look Forward. Okular does it.

Sorry, I meant *let's* close it.

I'd also propose closing this. Okular has this function.

I agree on closing this bug. This application seems to be no more developed.