Bug 99171

Summary: Recent list in KWrite does not update until you open the file a second time.
Product: [Applications] kate Reporter: Nils Andersson <nian2001>
Component: kwriteAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Nils Andersson 2005-02-12 02:44:39 UTC 
Version:           4.2.1 (using KDE 3.2.3, Mandrake Linux Cooker i586 - Cooker)
Compiler:          gcc version 3.4.1 (Mandrakelinux 10.1 3.4.1-4mdk)
OS:                Linux (i686) release 2.6.8.1-12mdk

This is how it works;
I open KWrite and save a (test) file.  Now this file does not show up in the
Recent list.  This could be expected since I already have it opened.

I close KWrite and open it again.  The last file I saved is now NOT in the
Recent list.  I would expect it to be,  since it's the most recent used.

I now open this file again and look in the Recent list and da-da,  there it
is at the top of the list.   

So,  I'll have to open the file a second time before it shows up.
Comment 1 Anders Lund 2005-02-17 13:53:42 UTC 
CVS commit by alund: 


Modify the recent files list whenever the filename changes.
BUG: 99171


  M +7 -1      kwritemain.cpp   1.110
  M +12 -7     kwritemain.h   1.28


--- kdebase/kate/app/kwritemain.h  #1.27:1.28
@@ -81,4 +81,9 @@ class KWrite : public KParts::MainWindow
     void slotEnableActions( bool enable );
 
+    /**
+     * adds a chenged URL to the recent files
+     */
+    void slotFileNameChanged();
+
   //config file functions
   public:

--- kdebase/kate/app/kwritemain.cpp  #1.109:1.110
@@ -101,4 +101,5 @@ KWrite::KWrite (KTextEditor::Document *d
   connect(m_view,SIGNAL(viewStatusMsg(const QString &)),this,SLOT(newStatus(const QString &)));
   connect(m_view->document(),SIGNAL(fileNameChanged()),this,SLOT(newCaption()));
+  connect(m_view->document(),SIGNAL(fileNameChanged()),this,SLOT(slotFileNameChanged()));
   connect(m_view,SIGNAL(dropEventPass(QDropEvent *)),this,SLOT(slotDropEvent(QDropEvent *)));
 
@@ -186,5 +187,4 @@ void KWrite::setupStatusBar()
 void KWrite::loadURL(const KURL &url)
 {
-  m_recentFiles->addURL( url );
   m_view->document()->openURL(url);
 }
@@ -272,4 +272,10 @@ void KWrite::slotOpen( const KURL& url )
 }
 
+void KWrite::slotFileNameChanged()
+{
+  if ( ! m_view->document()->url().isEmpty() )
+    m_recentFiles->addURL( m_view->document()->url() );
+}
+
 void KWrite::newView()
 {
Comment 2 Nils Andersson 2005-03-26 22:18:25 UTC 
Hi Anders!

Just updated and found my reported bug has been taken care of.
You guys are doing terrific work!!!  Thanks!

Clas

[bugs.kde.org quoted mail]

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/