| Summary: | Some camera client source files miss copyright and license info | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Achim Bohnet <ach> |
| Component: | Bundle-Tarball | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.1.0 | |
| Sentry Crash Report: | |||
severity levels between debian and kde differ: http://bugs.kde.org/bug_status.html#severity No comment :-) I seem to recall a big rework was done in files to put licence. But i cannot see it by now (since i don't have source code here.) Is it still valid? No nothing has changed in the mean time. See
head `licensecheck kipi-plugins/kameraklient/*.{cpp,h} | grep -h no\ | awk -F: '{print $1}'`
There must be something in the digikam-* mailing list archives. AFAIR
we tried to contact Tudor(?) without success.
Achim
Here is the situation:
find . -name "*.h" -exec licensecheck {} \; | grep -v GPL
./libkipi/libkipi/KDStream.h: UNKNOWN
./kipi-plugins/kameraklient/mtlist.h: no copyright
./kipi-plugins/kameraklient/cameraselection.h: no copyright
./kipi-plugins/kameraklient/thumbitem.h: no copyright
./kipi-plugins/kameraklient/mtqueue.h: no copyright
./kipi-plugins/kameraklient/thumbview.h: no copyright
./kipi-plugins/kameraklient/savefiledialog.h: no copyright
./kipi-plugins/jpeglossless/jinclude.h: UNKNOWN
./kipi-plugins/jpeglossless/jpegint.h: UNKNOWN
./kipi-plugins/jpeglossless/transupp.h: UNKNOWN
./libkeg/version.h: no copyright
find . -name "*.cpp" -exec licensecheck {} \; | grep -v GPL
./libkipi/libkipi/KDStream.cpp: UNKNOWN
./libkipi/libkipi/mainpage.cpp: no copyright
./kipi-plugins/kameraklient/cameraselection.cpp: no copyright
./kipi-plugins/kameraklient/thumbitem.cpp: no copyright
./kipi-plugins/kameraklient/thumbview.cpp: no copyright
./kipi-plugins/kameraklient/savefiledialog.cpp: no copyright
how about changing them, since the kipi-plugins are changing
the maintainers? I believe there could be problems having
non gpl plugins, am i worng?
Hello Tudor, I am in the process of taking over the maintenance of the KameraKlient plugin you created, based on previous Digikam code. At the moment some files are missing copyright and license info, see: http://bugs.kde.org/show_bug.cgi?id=99157 Would you mind if I place all kameraklient under the GPL? Regards, Aur SVN commit 531203 by gateau: Added missing copyrights, based on Digikam CVS: http://cvs.sourceforge.net/viewcvs.py/digikam/digikam3/digikamcameraclient/cameraui/ BUG: 99157 M +15 -0 cameraselection.cpp M +15 -0 cameraselection.h M +16 -0 mtlist.h M +16 -0 mtqueue.h M +16 -0 savefiledialog.cpp M +16 -0 savefiledialog.h M +15 -0 thumbitem.cpp M +15 -0 thumbitem.h M +15 -0 thumbview.cpp M +15 -0 thumbview.h This component is not maintained in KDE4 Gilles Caulier |
Version: 0.1.1 (using KDE 3.3.2, (3.1)) Compiler: gcc version 3.3.5 (Debian 1:3.3.5-6) OS: Linux (i686) release 2.6.10-1-686 I really hope that this will be resolved before 0.1.1 release. $ licensecheck kipi-plugins/kameraklient/{*.h,*.cpp} | grep -v GPL kipi-plugins/kameraklient/cameraselection.h: no_copyright kipi-plugins/kameraklient/mtlist.h: no_copyright kipi-plugins/kameraklient/mtqueue.h: no_copyright kipi-plugins/kameraklient/savefiledialog.h: no_copyright kipi-plugins/kameraklient/thumbitem.h: no_copyright kipi-plugins/kameraklient/thumbview.h: no_copyright kipi-plugins/kameraklient/cameraselection.cpp: no_copyright kipi-plugins/kameraklient/savefiledialog.cpp: no_copyright kipi-plugins/kameraklient/thumbitem.cpp: no_copyright kipi-plugins/kameraklient/thumbview.cpp: no_copyright Achim