| Summary: | Cannot send inline OpenPGP-signed messages | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Thiago Macieira <thiago> |
| Component: | encryption | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ana, arvidjaar |
| Priority: | NOR | ||
| Version: | SVN (3.5 branch) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Attempt at fixing the proble | ||
|
Description
Thiago Macieira
2005-02-11 03:05:28 UTC
On Friday 11 February 2005 03:05, Thiago Macieira wrote: > No matter what my choice in the dropdown list is, the > message is always sent using OpenPGP/MIME Did you check for per-recipient crypto preference (in kaddressbook)? This overrides the toolbar choices. > I had been worried that pgpType was at fault here No - that problem was for the (not completely ported) *reader* code. The sending of encrypted/signed messages is completely independent from that. Either there's a bug in keyresolver.cpp, or you have a per-contact crypto preference. > Did you check for per-recipient crypto preference (in kaddressbook)? This
> overrides the toolbar choices.
Yes. There are no addressbook-contacts for those recipients.
I have tried creating a contact, selecting inline OpenPGP as the only allowed crypto protocol and sending an email to that address.
OpenPGP/MIME was used.
Using Kmail 1.8 I have a similar problem. Without having the contact in kadressbook and choosing inline PGP signing results in a multipart/signed email. Sending an email to somebody in the kadressbook the same happens, if I allow inline OpenPGP and OpenPGP/MIME in kadressbook.
> I have tried creating a contact, selecting inline OpenPGP as the only
> allowed crypto protocol and sending an email to that address.
> OpenPGP/MIME was used.
Contrary to this, I do get an inline-signed email, when I only allow inline OpenPGP in kadressbook.
Using Kmail 1.8, I am seeing similar behaviour. If I have an email address in kaddressbook, I can set inline OpenPGP and the mail will be signed in-line. However, if the email address is not in kaddressbook, the signature and mail are sent as attachments even when Inline OpenPGP (deprecated) is selected. *** Bug 106837 has been marked as a duplicate of this bug. *** I think I have found the problem. Kleo::KeyResolver::resolveSigningKeysForSigningOnly (kdepim/kmail/keyresolver.cpp) does not check for the option selected in the drop-down box in the toolbar. Instead, it simply relies on what the recipients' configuration is in kaddressbook. It should be modified to try the chosen option only, unless that option is "Any". The same is probably true for resolveSigningKeysFroEncryption and resolveEncryptionKeys, but I didn't analyse them. Created attachment 11582 [details]
Attempt at fixing the proble
This simple two-line patch has fixed the problem for me.
SVN commit 429061 by tilladam: Fix by Thiago Macieira <thiago@kde.org> for ingored signature type selections. Marc, this seems correct to me. How about resolveSigningKeysFroEncryption and resolveEncryptionKeys? Do they have the same problem? BUG: 99089 CCMAIL: marc@kdab.net M +4 -2 keyresolver.cpp --- trunk/KDE/kdepim/kmail/keyresolver.cpp #429060:429061 @@ -2,7 +2,7 @@ keyresolver.cpp This file is part of libkleopatra, the KDE keymanagement library - Copyright (c) 2004 Klar It would have been *really* nice if somebody had remembered to commit this to branches/3.4 (the /bugfix/ branch back at that time ...) as well. Probably too late now. |