Bug 98986

Summary:	Only show thread operations for threaded messages
Product:	[Unmaintained] kmail	Reporter:	Sean Lynch <techniq35>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	bjoern, jonas.vejlin
Priority:	NOR
Version:	1.7.92
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot

Description Sean Lynch 2005-02-10 01:35:42 UTC

Version:           1.7.92 (using KDE 3.3.92 (beta2), compiled sources)
Compiler:          gcc version 3.3.3 (SuSE Linux)
OS:                Linux (i686) release 2.6.11-rc1-ck1

If you have threading for message enabled (Folder->Thread Message) then right clicking on any message, whether it is part of a thread or not, will show operations only pertinent to threaded messages (simply, it duplicates the same thing issuing the normal message operations would).

It would be best to only these operations when a message is in a thread.  On a side note (and will probably need to open a separate report), it would be nice and cleaner if all the Thread operations were grouped under a submenu, to not clutter the context menu.

Comment 1 Till Adam 2005-02-13 12:51:33 UTC

CVS commit by tilladam: 

Enable thread actions only for single messages which are part of a thread
and for multiple messages if they are part of the same thread.

BUGS: 98986


  M +8 -2      kmmainwidget.cpp   1.315


--- kdepim/kmail/kmmainwidget.cpp  #1.314:1.315
@@ -2881,6 +2881,8 @@ void KMMainWidget::updateMessageActions(
     updateListFilterAction();
 
-    bool allSelectedInCommonThread = true;
+    bool allSelectedInCommonThread = false;
+    bool singleMailIsPartOfThread = false;
     if ( count > 1 && mHeaders->isThreaded() ) {
+      allSelectedInCommonThread = true;
       QListViewItem * curItemParent = mHeaders->currentItem();
       while ( curItemParent->parent() )
@@ -2897,8 +2899,12 @@ void KMMainWidget::updateMessageActions(
       }
     }
+    if ( mHeaders->isThreaded() && count == 1 ) {
+      QListViewItem *cur = mHeaders->currentItem();
+      singleMailIsPartOfThread = cur->parent() || cur->childCount() > 0;
+    }
 
     bool mass_actions = count >= 1;
     bool thread_actions = mass_actions &&
-           allSelectedInCommonThread &&
+           ( allSelectedInCommonThread || singleMailIsPartOfThread ) &&
            mHeaders->isThreaded();
     mStatusMenu->setEnabled( mass_actions );

Comment 2 Sean Lynch 2005-11-22 19:38:08 UTC

Created attachment 13599 [details]
Screenshot

This seems to have returned (I've actually noticed it for a while in SVN.. but
forgot I had a bug opened for it).  Notice the email I have right clicked on is
a solitary message, yet it shows options for threaded messages (its just
unneeded options which clutter the menu and could confuse a user)

Comment 3 Sean Lynch 2005-11-22 19:38:48 UTC

Oops.. forgot to reopen bug.. see comment/screenshot above

Comment 4 Jonas Vejlin 2009-04-04 10:12:58 UTC

do you still have the problem with recent version?

Comment 5 Björn Ruberg 2009-12-20 22:31:28 UTC

Well, I still see for unthreaded messages the option "Mark Group as" in KDE 4.3- think this is what this bug adresses.

Comment 6 Laurent Montel 2015-04-12 10:22:58 UTC

Thank you for taking the time to file a bug report.

KMail2 was released in 2011, and the entire code base went through significant changes. We are currently in the process of porting to Qt5 and KF5. It is unlikely that these bugs are still valid in KMail2.

We welcome you to try out KMail 2 with the KDE 4.14 release and give your feedback.