Bug 98979

I can confirm this is the case using a recent cvs HEAD build (20050208).  Maps.google.com loads the basic interface around the map, but the map is blank and does not work.

Spoof as Safari and much more of the interface will work. Funnily up and down seems reversed.

Hmmm, I tried the spoof as Safari trick and I got it to show the map. At that point konqueror locked up and I got the "A script on this page is causing KHTML to freeze do you want to stop it" message.  I clicked no and konqueror continued to use 100% of the cpu untill I killed it.

I think it would be nice to get this working as well...

I can confirm the 100% CPU on the spoofing as safari trick.

I think it would be nice to get this working as well...

I can confirm the 100% CPU on the spoofing as safari trick.

I can confirm the "A script on this page is causing KHTML to freeze ..." using Konqueror of KDE 3.4 from SuSE on SuSE9.2.

This is the code snippet that's causing the infinite loop.  It appears as if with the other JS implementations out there, builtins take precedence.  This happens whether or not you spoof Safari.

// Copyright 2005 Google
var F=Number.MAX_VALUE;
var Na=0;
Object.prototype.setTimeout=function(a,b){
        var c="tempVar"+Na;
        Na++;
        eval(c+" = this;");
        var d=a.replace(/\\/g,"\\\\").replace(/\"/g,'\\"');
        return window.setTimeout(c+'._setTimeoutDispatcher("'+d+'");'+c+" = null;",b)
}

Reduced test case:

Object.prototype.closed = true;
document.write("Should see 3 times 'true' below:<br><br>");
document.write(Number().closed + "<br>");
document.write(!closed + "<br>"); 
document.write(!window.closed + "<br>");

SVN commit 420390 by porten:

fixed prototype property lookup order of global window object.
Fixes endless loop on maps.google.com.

BUGS:98979


 M  +6 -0      ChangeLog  
 M  +16 -3     ecma/kjs_window.cpp  


--- trunk/KDE/kdelibs/khtml/ChangeLog #420389:420390
@@ -1,3 +1,9 @@
+2005-06-01  Harri Porten  <porten@kde.org>
+
+	* ecma/kjs_window.cpp: fixed prototype property lookup order of
+	global window object. Fixes endless loop on maps.google.com
+	(bug #98979).
+
 2005-05-28  Allan Sandfeld Jensen <kde@carewolf.com>
 
         Implement ideographic enumeration including the CSS 2.1 cjk-ideographic and several from CSS 3 List (working draft).
--- trunk/KDE/kdelibs/khtml/ecma/kjs_window.cpp #420389:420390
@@ -487,10 +487,10 @@
   }
 
   // Look for overrides first
-  Value val = ObjectImp::get(exec, p);
-  if (!val.isA(UndefinedType)) {
+  ValueImp *val = getDirect(p);
+  if (val) {
     //kdDebug(6070) << "Window::get found dynamic property '" << p.ascii() << "'" << endl;
-    return isSafeScript(exec) ? val : Undefined();
+    return isSafeScript(exec) ? Value(val) : Undefined();
   }
 
   const HashEntry* entry = Lookup::findEntry(&WindowTable, p);
@@ -764,6 +764,19 @@
       return getListener(exec,DOM::EventImpl::UNLOAD_EVENT);
     }
   }
+
+  // doing the remainder of ObjectImp::get() that is not covered by
+  // the getDirect() call above.
+  // #### guessed position. move further up or down?
+  Object proto = Object::dynamicCast(prototype());
+  assert(proto.isValid());
+  if (p == specialPrototypePropertyName)
+    return isSafeScript(exec) ? Value(proto) : Undefined();
+  Value val2 = proto.get(exec, p);
+  if (!val2.isA(UndefinedType)) {
+    return isSafeScript(exec) ? val2 : Undefined();
+  }
+
   KParts::ReadOnlyPart *rop = part->findFramePart( p.qstring() );
   if (rop)
     return retrieve(rop);

This isn't fixed is it? I've just tried it, and I get the same results weather I spoof or not, and that's just a blank gray canvas. When I click on 'satellite' or 'hybrid' I broken pictures and information that says not available at this zoom.

This is Release 3.4.89 (>=20050615) Revision: 438930

Mostly works for me using 3.4.1/Linux/AMD64. You need to scroll the map before it displays anything, but all three modes - map, satellite and hybrid - do work and are useable albeit with the occasional glitch.

btw, 'Not available at this zoom' is a Google error - you have to Zoom out since they don't have any maps for that area at that zoom level.

Im using kde 3.4.1 on suse 9.3 and while the page loads the map images show as broken.

Konqueror from branches/KDE/3.5 revision 440440 works fine. It has been working for more than a month for me.

Please test again when KDE 3.5 alpha 1 is out.

I have a similar problem with maps.google.com:

I just tried to open http://maps.google.com/maps?oi=map&q=San+Diego,+CA (got this link from planetkde ...) and it seems that konqueror is hanging in a kind of loop while loading the page (nothing is shown then) - it seems that konqui is constantly reloading a small picture.

I'm using recent kde-3.5 from svn, svn info in kdebase/konqueror shows rev. 469327

greetings,
thomas

Please re-open this bug! it is not fixed. I am using KDE 3.5beta2 (svn Updated to revision 475138.)


http://maps.google.com is having a loop, even if I use konqueror as firefox agent.

ok, it's working with safari agent. but could you please make it "safari" by default for maps.google.com until it is fully fixed for google or konqueror?

Created attachment 13188 [details]
Google maps are not displayed

I am using KDE 3.5beta2 Updated to revision 475138.

It's more obvious like this:

http://maps.google.com/maps?ll=64.096985,-17.225189&spn=0.418854,0.792389&t=k&hl=en

Links to maps.google.com does not work, and never has.

The fact that you can't start maps.google.com without changing the ID is a stupid mistake on Google's part. Please yell at them and have them fix their stupidity. Report any progresses on bug 114793.

We will not ship any modified UAs for any site.

I  am on KDE 3.5 and can confirm that this bug is also present on http://maps.google.co.uk . It is really annoying. It appears to be stuck with loading an image and keeps retrying.

It would be great if this was fixed.

Ian: that bug is a bug in maps.google.com and not in Konqueror. Change your identification to Safari and it'll load.

maps.google.com appears to work for me now without spoofing UA, it also does not go into an endless loading stage as before. maps.google.com may have changed as this is with stock KDE 3.5/Gentoo.

With regards to Allan, is your link supposed to point to a satellite image of Iceland? That is what appears for me when opening the link.

Seems to work novadays without UA spoofing.