Bug 98822

Sorry, this is a WONTFIX. We've added the "Delete" option to the context-menu due to popular demand, and find it very useful. We won't remove it.

Also, as you say, there is a safety check, which protects from accidental use.

How about an option to remove it?

I'd also like to not have it there on my setup.

Thanks!

The 'Delete File' option is really annoying to me, too. I think the best way would be an option to turn it off like in the konqueror:
"[] Show 'Delete File' context menu entry in the playlist"

I think there should be a send to trash option instead of or as well as the delete button. That way you can recover the file if needed.

I also would think it should be removed or at least made an option or a send to trash (comment #3 and #4), I *have* accidently deleted some files. Even if you say it is a "wontfix" - I give it a 20 vote. What's wrong with an option/trash?

Additional proposal: could you at least seperate the two entries from each other? Maybe "delete file" in a submenu (one klick more safety) or just move the "delete from playlist" to the top of the context menu below "play" and "send to queue"? That would help a lot.

Changing into "send to trash" sounds very reasonable. If nobody opposes, I'll look into that later.

I oppose. I wouldn't like deleted files to take up harddisk space, hanging around in the trash folder. I delete them to free up space, after all.

If anything I think this should be an option. But adding yet another option sucks too, I guess.

It doesn't really affect me because I normally have my music partition mounted readonly, but I neither like it to be able to irreversibly delete a file in the playlist item context menu.

Even amaroK's filebrowser can't delete files but only move them to trash. (But I wouldn't mind if it could, because you see the files in it and intuitively know you are doing something with the files).

On Tuesday 19 April 2005 14:07, Stefan Siegel wrote:
> Even amaroK's filebrowser can't delete files but only move them to trash.


That's news to me. Mine has always deleted files.

Sorry, I just discovered this new feature in KDE 3.4. The "delete" command is hidden everywhere unless explicitly enabled. Perhaps we could re-use the setting? It is in kdeglobals/KDE/ShowDeleteCommand.

The idea of moving to trash has never made any sense to me. If you don't wish to remove the file completely, leave it alone. 

Moving to thrash, in amaroK, makes no sense.

But a option to disbale/remove this command would be a rather great idea.

I also find it annoying, when holding a greater party and beeing stressed, that I have to concentrate on not deleting the greatest song on earth.

> Moving to thrash, in amaroK, makes no sense.

Why not? For me it makes sense. I separate the songs I maybe want to delete from the others. Just "Del", no questions, temporarily gone. Checking "thousands" ;) of songs and having to answer a "Do you really want to delete" question on every "Del" is annoying and slows one down. But I wouldn't want a real delete without a safety question for so important data. So trash makes sense :) The space is freed up when I have checked the new songs. No waste of space :)

*** This bug has been confirmed by popular vote. ***

The system I use has many partitions so "Move to Trash" is extremely annoying to me since it takes to long. Until kde has a separate trash folder per partition, this should not be implemented

How about at least moving the 'Remove from Playlist' item below the 'Stop Playing after this track' item?

'Remove from Playlist' being a completely safe and reversible command should be separated from the 'Delete File' command, and I think it fits pretty well in the first category at the top.

> How about at least moving the 'Remove from Playlist' item below the 'Stop Playing after this track' item?

>> Comment #6 From Janet 2005-04-18
>> move the "delete from playlist" to the top of the context menu below "play" and "send to queue"?

Yes, I fully agree, it belongs into the first category of the context menu. The real delete should stand alone.

I add my voice to say that it is very unsafe to have the "delete file" entry near the "remove from playlist" entry: i just accidently deleted some of my mp3 files...
My prefered would be to have the "delete file" entry optional.

i'd prefer 'Send to Trash' because i nearly deleted some files by accident. if i want to delete some files in Konqueror i simply hold the shift key while pressing 'send to trash' menu. the files in this case are deleted and not send to trash. 
is it possible to change amarok that it behaves like Konqueror? 
or can somebody tell me in which amarok file the changes must be done? 
i have some (very rudimentary) c++ knowledge and maybe could do the change by myself.

I've voted for this bug, but the solution I prefer is :
 - move "remove from PL" under "stop after this track" in the right-click menu
 - the delete item do not remove from file-system but move to trash. Even though, pressing [shift] allowto remove definitively the file, as konqueror does, see AndyMeyer's last post)
 - This delete item could be desactivated by configuration option (by eg in General->playlist configuration dialog)

This is my point of view :-)

An other idea to remove the confusion between the 2 items, would be to changes icon of "remove from PL" to a minus. I think the trash icon is not appropriated to the action, that do not send to trash, but simply exclude the collection's entry from the playlist.

Bobuse is right. Every user should be able to decide if he/she wants a real delete or a send to trash. My vote goes for it. So please make that misplaced delete an option to show a move to trash instead. And yes, I also agree to Janet, Arnaud, bobuse and others that the menu item to delete (or move to trash) does not belong to remove from playlist and should be separated in the menu. 

Another suggestion to solve this issue:
Replace the delete with a "show the file in the filebrowser". This way you can not only delete the file but also rename or move it (or whatever). But it requires some more clicks.
Or even better:
An option to synchronize the filebrowser with the playlist so the playing song is shown in the filebrowser (if the filebrowser is selected). It should be quckly switchable so a buttom somewhere would be nice. This would be my prefered solution but maybe it's not that easy to implement.
I really dislike the current situation, actions in the playlist window should only affect playlists and tags. For file operations there's the filebrowser. It's a matter of safety.

> actions in the playlist window should only affect playlists and tags

couldn't agree more. The file operations should be in the collection and filebrowser only. At least seperate them it's confusing.

I would also prefer the solution to act like konqueror (and use the same settings as konqueror, if you want a real delete by default, or just with shift key)
I would even more prefer to just be able to delete/move to trash in the collection... or at least delete in any way in the collection additionally..
At the moment it doesnt make much sense, you can delete it when in the playlist, but not when in the collection-search-view ...

There is a 'Delete' sub-menu entry below the 'Manage Files' right-click menu entry.

> There is a 'Delete' sub-menu entry below the 'Manage Files' right-click menu entry. 

Now that you say it I have found it in the 1.4 version (not 1.3.x). But why is it in a submenu in the collection browser (where I would expect it to be in the root menu) and why in the playlist *not* in a submenu - where it would be "safe"? If you don't want to replace this "delete" in the playlist with a "send to trash" - please at least put it into a submenu like it is in the collection browser (more safe, more consistent).  

SVN commit 530490 by illissius:

respect Konqueror's setting for showing Delete in the menu, if the setting is there (e.g. Konqueror is installed), and KDE is 3.4 or higher
(with 3.3, it should work as before, but if someone with 3.3 would test it, we'd know for sure.)
BUG:98822


 M  +2 -0      ChangeLog  
 M  +6 -0      src/amarok.h  
 M  +23 -6     src/app.cpp  
 M  +7 -1      src/app.h  
 M  +17 -4     src/collectionbrowser.cpp  
 M  +44 -5     src/playlist.cpp  
 M  +1 -0      src/playlist.h  

>respect Konqueror's setting for showing Delete

Do I get it right: the "delete file" in the amaroK playlist is now dependend from the konqueror setting to show a real delete in the filemanager? That means if I have enabled konqueror to show the real delete menu item (and it is always enabled), I will also still have that "delete file" in amaroK's playlist? That wouldn't solve the problem. 

For all people who want an option to disable the "Delete File" in the context menu: Take a look at Wish 127006
http://bugs.kde.org/show_bug.cgi?id=127006

*** Bug 127006 has been marked as a duplicate of this bug. ***

I do think the "delete file" option is rather dangerous for a music collection. I know that there still is a warning message before a file is deleted, however I can imagine that such a message is overlooked in a stressful situation. Furthermore most people don't read any questions in popup windows and if one of my friends is using my amaroK I can not control what he is doing. Especially if I have a party at home and some people may be drunk ;)

I know that "delete file" in the amaroK playlist is now dependend from the konqueror setting to show a real delete or the trash can in the filemanager. But this does not help because many people only use "Delete" and not "Send to trash" in Konqueror.

I think the best way would be an option to turn it off like in the konqueror:
"[] Show 'Delete File'/'Send to trash' context menu entry in the playlist"

I don't want to concentrate on not deleting the greatest songs on earth :) 

Created attachment 16019 [details]
juk example

I would like to suggest that we mimic the way that juk handles this. I think
juk has an elegant solution to this problem.

juk has a "delete" option in the context menu.
It then comes up with a confirmation dialog asking if you definetely want to
send to trash or cancel. There is also a checkbox there asking if you want to
delete instead of sending to trash. And if you selected delete instead of trash
last time, it remembers it for the next time.

It's not that easy to explain in words so check out the app yourself, and also
have a look at the attached screenshot.

I agree Lex, that is an excellent idea. I'll look into doing this.

Reading the last comments I guess this still is *not* fixed? Or is there finally a way to have a "send to trash" in the amarok playlist (and no "delete") while at the same time having a real delete in the konqueror context menu?

I couldn't break the string freeze for 1.4.0 and then didn't get around to commit it before I left for Europe for 2 weeks. I'll commit the fix this weekend when I return home.

Just want to say I like the actual 1.4.3 solution: Delete moved to submenu Filemanagement plus the user can decide if the file shall be sent to trash or not. For me that is perfect - thank you :)