| Summary: | import: skips classes with comment in class decl | ||
|---|---|---|---|
| Product: | [Applications] umbrello | Reporter: | Enrico Ros <eros.kde> |
| Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
CVS commit by okellogg:
BUG:98603 - parseClassSpecifier(): Skip Token_comment before '{'
M +2 -1 ChangeLog 1.67
M +5 -0 umbrello/classparser/parser.cpp 1.11
--- kdesdk/umbrello/ChangeLog #1.66:1.67
@@ -28,5 +28,6 @@
92781 92995 93122 93219 93297 93298 93501 93535 93696 94173
94728 94795 94883 95082 95247 95252 95722 95924 95951 95954
-96216 96221 96964 97155 97182 97697 97887 97984 98899 99697
+96216 96221 96964 97155 97182 97697 97887 97984 98603 98899
+99697
Version 1.3
--- kdesdk/umbrello/umbrello/classparser/parser.cpp #1.10:1.11
@@ -1876,4 +1876,9 @@ bool Parser::parseClassSpecifier( TypeSp
}
+ QString comment;
+ while (lex->lookAhead(0) == Token_comment) {
+ comment += lex->lookAhead(0).text();
+ lex->nextToken();
+ }
if( lex->lookAhead(0) != '{' ){
lex->setIndex( start );
|
Version: 1.3.92 (using KDE 3.3.92 (beta2), compiled sources) Compiler: gcc version 3.3.3 20040412 (Gentoo Linux 3.3.3-r6, ssp-3.3.2-2, pie-8.7.6) OS: Linux (i686) release 2.6.10-gentoo-r6 Umbrello doesn't import classes declared like this: class MyClass : public ParentClass // comment that blocks importing { ... }; Removing the comment makes the class importable. (Noticed on kdegraphics/kpdf/core/document.h class KPDFDocument - I now removed the comment that blocked import of KPDFDocument). Thanks for the great umbrello!