Bug 97920

Summary:	progressbar does not show progress for imap uploading activity
Product:	[Unmaintained] kmail	Reporter:	Ferdinand Gassauer <gassauer>
Component:	IMAP	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	jtamate, kdebugs, lemma, ralf.hildebrandt
Priority:	NOR	Keywords:	triaged
Version:	1.7.92
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ferdinand Gassauer 2005-01-26 09:04:09 UTC

Version:           1.7.92 (using KDE 3.3.91 (beta1), compiled sources)
Compiler:          gcc version 3.3.4 (pre 3.3.5 20040809)
OS:                Linux (i686) release 2.6.8-24.11-smp

Hi!
kmail shows 2 (or more) progressbars with 0% for "Moving message" and "uploading message data" while uploading
cu
ferdinand

Comment 1 Carsten Burghardt 2005-02-01 22:24:58 UTC

Do you mean uploads from local to imap? This should be fixed when you update.

Comment 2 Ferdinand Gassauer 2005-02-03 16:16:18 UTC

yes, that's what I ment.

but unfortunately it still does not show any progress - cvsup from this morning

Comment 3 Carsten Burghardt 2005-02-20 18:52:52 UTC

CVS commit by burghard: 

Show an accurate progress dialog at least when 1 message is uploaded.
For several messages the progress shows only the overall status but this can only
be changed in the progressmanager api which is probably a past-3.4 task.
CCMAIL: 97920@bugs.kde.org


  M +3 -2      imapjob.cpp   1.78
  M +4 -2      kmfolderimap.cpp   1.254


--- kdepim/kmail/kmfolderimap.cpp  #1.253:1.254
@@ -438,8 +438,10 @@ int KMFolderImap::addMsg(QPtrList<KMMess
     }
     imapJob = new ImapJob( msgList, QString::null, ImapJob::tPutMessage, this );
-    if ( !mAddMessageProgressItem )
+    if ( !mAddMessageProgressItem && msgList.count() > 1 )
     {
+      // use a parent progress if we have more than 1 message
+      // otherwise the normal progress is more accurate
       mAddMessageProgressItem = ProgressManager::createProgressItem(
-          "ImapJobUploading"+ProgressManager::getUniqueID(),
+          "Uploading"+ProgressManager::getUniqueID(),
           i18n("Uploading message data"),
           i18n("Destination folder: ") + folder()->prettyURL(),

--- kdepim/kmail/imapjob.cpp  #1.77:1.78
@@ -127,5 +127,6 @@ void ImapJob::init( JobType jt, QString 
       ImapAccountBase::jobData jd;
       jd.parent = 0; jd.offset = 0; jd.done = 0;
-      jd.total = curMsg->msgSizeServer();
+      jd.total = ( curMsg->msgSizeServer() > 0 ) ? 
+        curMsg->msgSizeServer() : curMsg->msgSize();
       jd.msgList.append( curMsg );
       QCString cstr( curMsg->asString() );
@@ -151,5 +152,5 @@ void ImapJob::init( JobType jt, QString 
           "ImapJobUploading"+ProgressManager::getUniqueID(),
           i18n("Uploading message data"),
-          i18n("Destination folder: ") + mDestFolder->prettyURL(),
+          curMsg->subject(),
           true,
           account->useSSL() || account->useTLS() );

Comment 4 Thomas McGuire 2007-06-25 22:40:57 UTC

*** Bug 147215 has been marked as a duplicate of this bug. ***

Comment 5 Shem Valentine 2008-09-14 21:22:59 UTC

I was unable to reproduce this using kmail 1.10.1.

When moving messages from local to IMAP I get an overall progress bar which is accurate and individual progress bars for each message which also appear accurate.

Comment 6 Jaime Torres 2008-09-16 20:09:33 UTC

it works for me also in trunk.