Bug 97297

Summary: Playlist-Browser should not sort playlists alphabetically
Product: [Applications] amarok Reporter: Dhraak
Component: generalAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 1.2-CVS   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Dhraak 2005-01-18 04:06:11 UTC 
Version:           1.2-CVS (using KDE 3.3.91 (beta1), Gentoo)
Compiler:          gcc version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
OS:                Linux (i686) release 2.6.7-gentoo-r4

the contents of playlists in the playlists browser appear to be sorted alphabetically by title.

When I drag the saved playlist from the playlist browser to the current playlist, the correct order is restored.

However, I think that the correct, non-sorted order (as it was when the playlist was saved) should be displayed in the playlists browser as well.
Comment 1 Elan Ruusamäe 2005-07-07 10:19:48 UTC 
agree here, my version amarok 1.3-beta2
Comment 2 Greg Meyer 2005-08-15 21:27:47 UTC 
Can you update to 1.3 final and see if this is still happening?
Comment 3 Alexandre Oliveira 2005-08-15 21:51:04 UTC 
Yep, this one I can confirm myself Greg. A workaround is setting "Unsorted" in the Playlist Browser configuration menu, but the sorting options should apply only to the playlists, not to the playlists item.
Comment 4 Alexandre Oliveira 2005-08-16 02:56:41 UTC 
SVN commit 449581 by aoliveira:

Don't sort playlist and podcasts items.
Hey, it was easy!
BUG: 97297


 M  +5 -0      playlistbrowseritem.h  


--- trunk/extragear/multimedia/amarok/src/playlistbrowseritem.h #449580:449581
@@ -137,6 +137,9 @@
         PlaylistEntry( QListViewItem *parent, QListViewItem *after, const KURL &, int tracks=0, int length=0 );
         PlaylistEntry( QListViewItem *parent, QListViewItem *after, QDomElement xmlDefinition );
         ~PlaylistEntry();
+
+        void sortChildItems ( int /*column*/, bool /*ascending*/ ) { /* Don't sort its children */ }; //reimplemented
+
         void load();
         void restore();
 
@@ -276,6 +279,8 @@
         PodcastChannel( QListViewItem *parent, QListViewItem *after, const KURL &url,
                         QDomNode channelSettings, QDomDocument xml );
 
+        void sortChildItems ( int /*column*/, bool /*ascending*/ ) { /* Don't sort its children */ }; //reimplemented
+
         void setNew( bool n = true );
         bool hasNew() { return m_new; }