Summary: | kpdf crashes scrolling thumbnail bar (backtrace) | ||
---|---|---|---|
Product: | [Applications] kpdf | Reporter: | Andreas Leuner <almighty> |
Component: | general | Assignee: | Albert Astals Cid <aacid> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Andreas Leuner
2005-01-16 11:35:05 UTC
BTW, I just learned that none of those kpdf processes were killed after closing drkonqi. I had to kill them "manually". For reference the same crash happens on the first page of http://www.ozgear.com.au/scgi-bin/load.cgi?yaesu/PDF/FT-857.pdf CVS commit by aacid: xpdf code is not prepared for paths with only 1 point, skip paths that have only one point, have to check in pdf spec if paths can have 1 point (in that case should fix the fix :-) or that pdf are buggy and the fix is correct in all senses. Pages that crash are 18, 20 and 26 on Introduction_to_Jitter.pdf and page 1 on FT-857.pdf BUG: 97131 M +1 -0 TODO 1.21 M +1 -1 xpdf/splash/Splash.cc 1.2 --- kdegraphics/kpdf/TODO #1.20:1.21 @@ -86,4 +86,5 @@ -> use shortcuts for next and prev page even in presenatation mode (by Tobias Koenig) -> move some document related features from part to the document (see find, goto dialog, ...) +-> Albert: Read pdf specification and see if paths with length = 1 are allowed, in case they are allowed see how to fix 97131 without skipping paths with length = 1 Done (newest features come first): --- kdegraphics/kpdf/xpdf/splash/Splash.cc #1.1:1.2 @@ -629,5 +629,5 @@ SplashError Splash::fillWithPattern(Spla SplashClipResult clipRes, clipRes2; - if (path->length == 0) { + if (path->length == 0 || path->length == 1) { return splashErrEmptyPath; } Wow that was fast! I just came from lunch and this bug wasn't even in "my bugs" anymore. Thank you very much for that fix - works fine for me. |