Bug 96671

Summary:	Doesn't log channels with slashes in the name
Product:	[Applications] konversation	Reporter:	Michael Gabilondo <eno>
Component:	general	Assignee:	Ismail Donmez <ismail>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	0.15
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Michael Gabilondo 2005-01-09 23:05:31 UTC

Version:           0.15 (using KDE KDE 3.3.1)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-5) 
OS:                Linux

It doesn't log channels that have a '/' in them, like #gnu/linux. It also doesn't show the backlog for those channels.

Comment 1 argonel 2005-01-10 05:51:38 UTC

CVS commit by argonel: 

- replace / in channel logfile name with _
- silence warnings
CCBUG: 96671


  M +3 -3      chatwindow.cpp   1.112
  M +1 -1      chatwindowappearance_preferences.ui   1.6


--- kdeextragear-2/konversation/konversation/chatwindow.cpp  #1.111:1.112
@@ -241,5 +241,5 @@ void ChatWindow::append(const QString& n
 }
 
-void ChatWindow::appendQuery(const QString& nickname,const QString& message, bool usenotifications)
+void ChatWindow::appendQuery(const QString& nickname,const QString& message, bool)
 {
   Q_ASSERT(textView);  if(!textView) return ;
@@ -247,5 +247,5 @@ void ChatWindow::appendQuery(const QStri
 }
 
-void ChatWindow::appendAction(const QString& nickname,const QString& message, bool usenotifications)
+void ChatWindow::appendAction(const QString& nickname,const QString& message, bool)
 {
   Q_ASSERT(textView);  if(!textView) return ;
@@ -301,5 +301,5 @@ void ChatWindow::setLogfileName(const QS
     } else if(m_server) {
       // make sure that no path delimiters are in the name
-      logName=m_server->getServerGroup().lower().replace("/","_")+"_"+name+".log";
+      logName=QString(m_server->getServerGroup().lower()).append('_').append(name).append(".log").replace('/','_');
     }
 

--- kdeextragear-2/konversation/konversation/chatwindowappearance_preferences.ui  #1.5:1.6
@@ -1,3 +1,3 @@
-<!DOCTYPE UI><UI version="3.3" stdsetdef="1">
+<!DOCTYPE UI><UI version="3.2" stdsetdef="1">
 <class>ChatWindowAppearance_Config</class>
 <comment>This program is free software; you can redistribute it and/or modify

Comment 2 Ismail Donmez 2005-01-10 09:06:19 UTC

*** Bug has been marked as fixed ***.

Comment 3 argonel 2010-07-01 15:55:26 UTC

commit 60ad124a7c89b279bfdc2228722bca312dbad469
Author: Eli MacKenzie <argonel@gmail.com>
Date:   Mon Jan 10 04:51:32 2005 +0000

    - replace / in channel logfile name with _
    - silence warnings
    CCBUG: 96671
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=377093

diff --git a/konversation/chatwindow.cpp b/konversation/chatwindow.cpp
index 159714a..059f04f 100644
--- a/konversation/chatwindow.cpp
+++ b/konversation/chatwindow.cpp
@@ -240,13 +240,13 @@ void ChatWindow::append(const QString& nickname,const QString& message)
   textView->append(nickname,message);
 }
 
-void ChatWindow::appendQuery(const QString& nickname,const QString& message, bool usenotifications)
+void ChatWindow::appendQuery(const QString& nickname,const QString& message, bool)
 {
   Q_ASSERT(textView);  if(!textView) return ;
   textView->appendQuery(nickname,message);
 }
 
-void ChatWindow::appendAction(const QString& nickname,const QString& message, bool usenotifications)
+void ChatWindow::appendAction(const QString& nickname,const QString& message, bool)
 {
   Q_ASSERT(textView);  if(!textView) return ;
   textView->appendAction(nickname,message);
@@ -300,7 +300,7 @@ void ChatWindow::setLogfileName(const QString& name)
       logName=name+".log";
     } else if(m_server) {
       // make sure that no path delimiters are in the name
-      logName=m_server->getServerGroup().lower().replace("/","_")+"_"+name+".log";
+      logName=QString(m_server->getServerGroup().lower()).append('_').append(name).append(".log").replace('/','_');
     }
 
     // "cd" into log path or create path, if it's not there
diff --git a/konversation/chatwindowappearance_preferences.ui b/konversation/chatwindowappearance_preferences.ui
index 4574418..c59dadc 100644
--- a/konversation/chatwindowappearance_preferences.ui
+++ b/konversation/chatwindowappearance_preferences.ui
@@ -1,4 +1,4 @@
-<!DOCTYPE UI><UI version="3.3" stdsetdef="1">
+<!DOCTYPE UI><UI version="3.2" stdsetdef="1">
 <class>ChatWindowAppearance_Config</class>
 <comment>This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by