Bug 96609

Summary:	if you insert a reminder-bar, all tabs blink as if something was said in these queries/channels
Product:	[Applications] konversation	Reporter:	Marcus Wolschon <Marcus>
Component:	general	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	0.15
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Marcus Wolschon 2005-01-09 00:01:04 UTC

Version:           0.15 (using KDE 3.3.2,  (3.1))
Compiler:          gcc version 3.3.5 (Debian 1:3.3.5-4)
OS:                Linux (i686) release 2.6.10

If you insert a reminder-bar (ctrl+R, "Merkerzeile" in German) all tabs blink even if there was no activity other then the insertion of the bar in these queries/channels.
The insertion of the bar should not trigger the blinking as you habe to visit all open tabs to check manually if anything happened there that you missed later even if nothing happened there. This is contrary to the purpose of the blinking tabs on activity.

Comment 1 Ismail Donmez 2005-02-02 21:17:02 UTC

I can't reproduce this. How can inserting reminder bar to one tab can effect other tabs?

Comment 2 Marcus Wolschon 2005-02-02 23:35:00 UTC

reminder bars are inserted into all tabs at once.
I can still reproduce it. I just press strg+R when I have
some other tabs with no activity (since I last read them) open.

Comment 3 Ismail Donmez 2005-02-02 23:38:30 UTC

Ok I see what you mean now.

Comment 4 Peter Simonsson 2005-04-01 18:35:54 UTC

CVS commit by psn: 

Don't blink tabs on insert remember line

BUG:96609


  M +1 -1      chatwindow.cpp   1.114
  M +2 -2      ircview.cpp   1.242
  M +1 -1      ircview.h   1.63


--- kdeextragear-2/konversation/konversation/chatwindow.cpp  #1.113:1.114
@@ -227,5 +227,5 @@ void ChatWindow::insertRememberLine()
   Q_ASSERT(textView);  if(!textView) return;
   kdDebug() << "Inserting remember line" << endl;
-  textView->appendRaw("<br><hr color=\"#"+KonversationApplication::preferences.getColor("CommandMessage")+"\" noshade>", true);
+  textView->appendRaw("<br><hr color=\"#"+KonversationApplication::preferences.getColor("CommandMessage")+"\" noshade>", true, true);
 }
 

--- kdeextragear-2/konversation/konversation/ircview.cpp  #1.241:1.242
@@ -518,5 +518,5 @@ void IRCView::append(const QString& nick
 }
 
-void IRCView::appendRaw(const QString& message, bool suppressTimestamps)
+void IRCView::appendRaw(const QString& message, bool suppressTimestamps, bool self)
 {
   QString channelColor=KonversationApplication::preferences.getColor("ChannelMessage");
@@ -532,5 +532,5 @@ void IRCView::appendRaw(const QString& m
     }
 
-  doAppend(line);
+  doAppend(line, true, self);
 }
 

--- kdeextragear-2/konversation/konversation/ircview.h  #1.62:1.63
@@ -78,5 +78,5 @@ class IRCView : public KTextBrowser
   public slots:
     void append(const QString& nick, const QString& message);
-    void appendRaw(const QString& message, bool suppressTimestamps=false);
+    void appendRaw(const QString& message, bool suppressTimestamps=false, bool self = false);
     void appendQuery(const QString& nick, const QString& message);
     void appendAction(const QString& nick, const QString& message);

Comment 5 Peter Simonsson 2010-07-01 16:02:01 UTC

commit f8eca4d3d37c9f09b41ed8e6f20a60e9152d5935
Author: Peter Simonsson <peter.simonsson@gmail.com>
Date:   Fri Apr 1 16:35:48 2005 +0000

    Don't blink tabs on insert remember line
    
    BUG:96609
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=402438

diff --git a/konversation/chatwindow.cpp b/konversation/chatwindow.cpp
index d593936..19a9b83 100644
--- a/konversation/chatwindow.cpp
+++ b/konversation/chatwindow.cpp
@@ -226,7 +226,7 @@ void ChatWindow::insertRememberLine()
 {
   Q_ASSERT(textView);  if(!textView) return;
   kdDebug() << "Inserting remember line" << endl;
-  textView->appendRaw("<br><hr color=\"#"+KonversationApplication::preferences.getColor("CommandMessage")+"\" noshade>", true);
+  textView->appendRaw("<br><hr color=\"#"+KonversationApplication::preferences.getColor("CommandMessage")+"\" noshade>", true, true);
 }
 
 void ChatWindow::appendRaw(const QString& message, bool suppressTimestamps)
diff --git a/konversation/ircview.cpp b/konversation/ircview.cpp
index 2c2596b..d92fc3f 100644
--- a/konversation/ircview.cpp
+++ b/konversation/ircview.cpp
@@ -517,7 +517,7 @@ void IRCView::append(const QString& nick,const QString& message)
   doAppend(line);
 }
 
-void IRCView::appendRaw(const QString& message, bool suppressTimestamps)
+void IRCView::appendRaw(const QString& message, bool suppressTimestamps, bool self)
 {
   QString channelColor=KonversationApplication::preferences.getColor("ChannelMessage");
   QString line;
@@ -531,7 +531,7 @@ void IRCView::appendRaw(const QString& message, bool suppressTimestamps)
       line = QString("<p>" + timeStamp() + " <font color=\"#" + channelColor + "\">" + message + "</font></p>\n");
     }
 
-  doAppend(line);
+  doAppend(line, true, self);
 }
 
 void IRCView::appendQuery(const QString& nick,const QString& message)
diff --git a/konversation/ircview.h b/konversation/ircview.h
index 8d2cf88..c49f6be 100644
--- a/konversation/ircview.h
+++ b/konversation/ircview.h
@@ -77,7 +77,7 @@ class IRCView : public KTextBrowser
 
   public slots:
     void append(const QString& nick, const QString& message);
-    void appendRaw(const QString& message, bool suppressTimestamps=false);
+    void appendRaw(const QString& message, bool suppressTimestamps=false, bool self = false);
     void appendQuery(const QString& nick, const QString& message);
     void appendAction(const QString& nick, const QString& message);
     void appendServerMessage(const QString& type, const QString& message);