Bug 95760

Summary: Document Relations, KDE, Konqueror, Linux, spawn, stack_check, bad void, forgot pull, forgot limit on stack
Product: [Applications] konqueror Reporter: Terry James <GinEric>
Component: generalAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED DUPLICATE    
Severity: crash    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Slackware   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Terry James 2004-12-24 04:06:59 UTC 
Version:            (using KDE KDE 3.3.2)
Installed from:    Slackware Packages
Compiler:          gcc-3.3.4 
OS:                Linux

Instantiation of Document Relations spawning is not resolved.

Although it says they are, they are not.

Problems and why:

01.)  KDE, Konqueror | Settings | Toolbars - Document Relations (Konqueror) ::=  Does not disable by default.  Perhaps after it is set and reset, it should not spawn 'any' Document Relations toolbars.

02.)  Spawning - this is a classical appearance of incomplete code.  Logically, no pre-check is made to see if Document Relations is turned off.  Furthermore, there is no apparent check for a limit of Document Relations toolbars spawning.  This looks so much like a PUSH STACK without a POP STACK at the end, or after RETURN, that I'd bet on it.

03.)  Settings too global, that is, even after Konqueror is completely shut down, the next call for Konqueror restores the spawn as well, i.e., it has not been shut off globally by the toolbar settings, but merely turned off for that particular session.  A definite no-no which will cause respawns.

04.)  It is annoying and distracting.  Pushing content off the window of focus by setting spawned toolbars onto the left-hand side of the window.  The focus should be content, not toolbars or Object Helpers, which this addon appears to be.

05.)  It ain't resolved til it's resolved.

Meanwhile, after completing the current compiles of things like KDE 3.3.4, Apache 2.0.52, MySQL 5.0.2, and PHP 5.0.3 for Slackware test packages, I may get time to hunt down this module and fork it to death!
:)
Comment 1 Maksim Orlovich 2004-12-24 04:11:44 UTC 

*** This bug has been marked as a duplicate of 86113 ***
Comment 2 Terry James 2004-12-26 23:05:08 UTC 
This bug has been marked as a duplicate of another so that it can be thrown in the trash and ignored until it is too late to fix it; just like Microsoft stuff.

How lazy can you get?
Comment 3 Maksim Orlovich 2004-12-27 00:05:23 UTC 
If you were a bit more attentive, and a bit less opinionated, you would have found out the bug was fixed on the 23rd. Unfortunately, you seem to prefer to speculate about stuff you are not familiar with at all.
Comment 4 Terry James 2004-12-27 00:16:56 UTC 
Too fast for me.  I would have suggested entirely eliminating Document Relations.

I couldn't find any fix and I was here on the 23rd; perhaps owing to the maze of resolved's  I was getting ready to compile KDE at that time.

I was here on the 24th, and the 25th; still did not find the bug solution.

And for someone who is "not familiar" with stuff, would you mind telling me the source code module?  That is, for the Document Relations addon?  How about the header file that the bug was found in?

What version will it be fixed in?

I want to confirm something, that Document Relations was handled before the Window initialization, and consequently took priority over the Settings.  I thought it was a bad call, out of order call, or a stack problem.

One more thing, I would add a "Disable Document Relations" option in Settings.

Tell me where the source module is, and I'll tell you everything that is wrong with the code.

According to many professors, my opinions are valid, even when attacked for merely having an opinion, and thus being human.
Comment 5 Maksim Orlovich 2004-12-27 22:40:12 UTC 
Everything you need to know is in comment #31 in the bug this was marked as duplicate of.