Bug 94883

Summary:	Just after loading a big model, the tree view is repainted each time is added a new item
Product:	[Applications] umbrello	Reporter:	Marcos Mayorga <drmay_en>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Marcos Mayorga 2004-12-11 01:12:21 UTC

Version:           1.3.90 (using KDE 3.3.89 (CVS >= 20041104), compiled sources)
Compiler:          gcc version 3.3.4 (Debian 1:3.3.4-13)
OS:                Linux (i686) release 2.6.8.1

The tree view should be drawn once after populating it, not hundreds of times, one per item added.

Comment 1 Oliver Kellogg 2004-12-11 13:17:49 UTC

CVS commit by okellogg: 

Avoid unnecessary repaints.
BUG: 94883


  M +2 -2      ChangeLog   1.45
  M +0 -1      umbrello/umldoc.cpp   1.211
  M +0 -1      umbrello/umllistview.cpp   1.130
  M +0 -6      umbrello/umlobject.cpp   1.58


--- kdesdk/umbrello/ChangeLog  #1.44:1.45
@@ -19,6 +19,6 @@
 89563 89579 89582 89699 89860 89903       90102 90106 90206
 90755       91298 91433 91494 91869 91922       92116 92123
-92222 92300 92301 92781 92995 93122 93501 93595 93696 94173
-
+92222 92300 92301 92781 92995 93122 93219 93501 93595 93696
+94173 94728 94883
 
 Version 1.3

--- kdesdk/umbrello/umbrello/umldoc.cpp  #1.210:1.211
@@ -2200,5 +2200,4 @@ bool UMLDoc::loadUMLObjectsFromXMI(QDomE
                 emit sigSetStatusbarProgress( ++m_count );
                  */
-                kapp->processEvents();  // give UI events a chance
         }
 

--- kdesdk/umbrello/umbrello/umllistview.cpp  #1.129:1.130
@@ -2443,5 +2443,4 @@ bool UMLListView::loadChildrenFromXMI( U
                 if (item)  {
                         item->setOpen( (bool)bOpen );
-                        kapp->processEvents();  // give UI events a chance
                         if ( !loadChildrenFromXMI(item, domElement) ) {
                                 return false;

--- kdesdk/umbrello/umbrello/umlobject.cpp  #1.57:1.58
@@ -15,5 +15,4 @@
 #include <qregexp.h>
 #include <kdebug.h>
-#include <kapplication.h>
 #include "umlobject.h"
 #include "uml.h"
@@ -335,5 +334,4 @@ bool UMLObject::resolveRef() {
                     m_BaseType != Uml::ot_Association && m_BaseType != Uml::ot_UMLObject)
                         umldoc->signalUMLObjectCreated(this);
-                kapp->processEvents();  // give UI events a chance
                 return true;
         }
@@ -349,5 +347,4 @@ bool UMLObject::resolveRef() {
                             m_BaseType != Uml::ot_Association && m_BaseType != Uml::ot_UMLObject)
                                 umldoc->signalUMLObjectCreated(this);
-                        kapp->processEvents();  // give UI events a chance
                         return true;
                 }
@@ -361,5 +358,4 @@ bool UMLObject::resolveRef() {
                             m_BaseType != Uml::ot_Association && m_BaseType != Uml::ot_UMLObject)
                                 umldoc->signalUMLObjectCreated(this);
-                        kapp->processEvents();  // give UI events a chance
                         return true;
                 }
@@ -394,5 +390,4 @@ bool UMLObject::resolveRef() {
                 }
                 m_pSecondary = pDoc->createUMLObject(ot, m_SecondaryId, NULL, true);
-                kapp->processEvents();  // give UI events a chance
                 // The `prepend' flag is set true because we need to move the
                 // newly created item to before the current item in UMLDoc's
@@ -421,5 +416,4 @@ bool UMLObject::resolveRef() {
             m_BaseType != Uml::ot_Association && m_BaseType != Uml::ot_UMLObject)
                 umldoc->signalUMLObjectCreated(this);
-        kapp->processEvents();  // give UI events a chance
         return true;
 }