Bug 93875

Summary:	Default is always selected in CDDB multiple match
Product:	[Unmaintained] kaudiocreator	Reporter:	Zamdee <zamdee>
Component:	general	Assignee:	Gerd Fleischer <gerdfleischer>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Zamdee 2004-11-25 01:23:10 UTC

Version:           1.12 (using KDE KDE 3.3.1)
Installed from:    Gentoo Packages
Compiler:          gcc 3.3.4 20040623 Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6
OS:                Linux

If KAudiocreator finds several matches for CD in freedb, it shows the dialog to select one. However it always uses the default selection even if I select another one.

Another related thing: If freedb entry has a genre not listed in KAudiocreator's genre list, the genre will convert to ACappella.

Comment 1 Richard Lärkäng 2004-11-29 19:01:13 UTC

CVS commit by larkang: 

It should be the other way around :-)

Fix choosing between cddb-entries when there
are more than one match

BUG: 93875


  M +1 -1      tracksimp.cpp   1.44


--- kdemultimedia/kaudiocreator/tracksimp.cpp  #1.43:1.44
@@ -459,5 +459,5 @@ void TracksImp::cddbDone(CDDB::Result re
                                 c++;
                         }
-                        if( cddb_info.size() <= c)
+                        if( c < cddb_info.size() )
                                 info = cddb_info[c];
                 } else {