Bug 93597

Summary: compile fails with koffice plugin
Product: [Applications] kmplayer Reporter: Carsten Lohrke <carstenlohrke>
Component: generalAssignee: Koos Vriezen <koos.vriezen>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Carsten Lohrke 2004-11-19 20:46:52 UTC
Version:           0.8.4_rc2 (using KDE KDE 3.3.1)
Installed from:    Gentoo Packages
Compiler:          3.4.3 
OS:                Linux

/bin/sh ../libtool --silent --mode=compile --tag=CXX i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/kde/3.3/include/kio -I/usr/kde/3.3/include -I/usr/qt/3/include -I/usr/X11R6/include -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -DNDEBUG -DNO_DEBUG -O2 -O3 -march=athlon-xp -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common  -c -o kmplayerbroadcast.lo `test -f 'kmplayerbroadcast.cpp' || echo './'`kmplayerbroadcast.cpp
kmplayer_koffice_part.cpp: In constructor `KOfficeMPlayer::KOfficeMPlayer(QWidget*, const char*, QObject*, const char*, bool)':
kmplayer_koffice_part.cpp:102: error: 'class KMPlayer' has no member named 'urlSource'
kmplayer_koffice_part.cpp: At global scope:
kmplayer_koffice_part.cpp:143: warning: unused parameter 'name'
kmplayer_koffice_part.cpp:85: warning: unused parameter 'args'
make[2]: *** [kmplayer_koffice_part.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/var/tmp/portage/kmplayer-0.8.4_rc2/work/kmplayer-0.8.4-rc2/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/kmplayer-0.8.4_rc2/work/kmplayer-0.8.4-rc2'
make: *** [all] Error 2


http://bugs.gentoo.org/show_bug.cgi?id=71648
Comment 1 Stephan Binner 2004-11-20 10:54:15 UTC
iirc a work-around is --enable-final
Comment 2 Koos Vriezen 2004-11-20 11:30:23 UTC
Hmm, yeah well kmplayer_koffice_part is not really supported now. The problem is that koffice does not allow embedded parts that wan't their own widget.
Anyway, the fix for the compile error with --enable-koffice-plugin is 
--- kmplayer_koffice_part.cpp   3 Aug 2003 20:15:35 -0000       1.3
+++ kmplayer_koffice_part.cpp   20 Nov 2004 10:26:17 -0000
@@ -99,7 +99,7 @@ KOfficeMPlayer::KOfficeMPlayer (QWidget
     setInstance (KMPlayerFactory::instance (), false);
     setReadWrite (false);
     m_player->init();
-    m_player->setSource (m_player->urlSource ());
+    m_player->setSource (m_player->sources () ["urlsource"]);
     //setWidget (view);
 }

I also get another error about missing loadOasis member. But might be from koffice CVS HEAD only.

Thanks for your report, did you really use kmplayer as a koffice plugin?
Comment 3 Carsten Lohrke 2004-11-20 16:04:18 UTC
>did you really use kmplayer as a koffice plugin?

I'm not using kmplayer at all. It's just, that we expose nearly all options to our Gentoo userbase. I wasn't sure about the status of this plugin, so I forwarded the linked bug report, to get exactly such an comment:

>Hmm, yeah well kmplayer_koffice_part is not really supported now.

I think I will remove the possibility to enable the plugin for now. Just a news item, if and when it will be revived would be fine.