Summary: | usability : The "Select Album" dialog should select the root directory by default and not the currently selected album in the top-most window | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Guillaume Pratte <guillaume.pratte> |
Component: | Usability-Ergonomy | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | rom1v |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 7.6.0 |
Description
Guillaume Pratte
2004-11-08 00:09:48 UTC
I think, selecting the current album is much more expected than always selecting the root album. Actually I would find that annoying. So we wont fix it. But what we can do: after closing the download dialog, the album to which the files were downloaded can be selected and opened. Le 7 Novembre 2004 18:40, Joern Ahrens a écrit : > I think, selecting the current album is much more expected than always > selecting the root album. Actually I would find that annoying. So we wont > fix it. > > But what we can do: after closing the download dialog, the album to which > the files were downloaded can be selected and opened. That seems like a good compromise. Guillaume Pratte CVS commit by jahrens: After closing the cameragui, the last destination is opened in digikam. Hope you can live with that, Guillaume. BUG: 92884 CCMAIL: joern.ahrens@kdemail.net, digikam-devel@lists.sourceforge.net M +5 -2 cameraui.cpp 1.30 M +5 -0 cameraui.h 1.16 --- kdeextragear-3/digikam/utilities/cameragui/cameraui.cpp #1.29:1.30 @@ -246,4 +246,7 @@ bool CameraUI::isBusy() const void CameraUI::closeEvent(QCloseEvent* e) { + if(!m_lastDestURL.isEmpty()) + emit signalLastDestionation(m_lastDestURL); + delete m_controller; saveSettings(); @@ -459,4 +461,5 @@ void CameraUI::slotDownload(bool onlySel return; + m_lastDestURL = url; m_progress->setProgress(0); m_progress->setTotalSteps(total); --- kdeextragear-3/digikam/utilities/cameragui/cameraui.h #1.15:1.16 @@ -97,4 +97,6 @@ private: CameraController* m_controller; + KURL m_lastDestURL; + private slots: @@ -126,4 +128,7 @@ private slots: void slotToggleAdvanced(); + +signals: + void signalLastDestionation(const KURL&); }; CVS commit by jahrens: ... was in the wrong directory during commit, so here is the rest :) After closing the cameragui, the last destination is opened in digikam. Hope you can live with that, Guillaume. BUG: 92884 CCMAIL: joern.ahrens@kdemail.net, digikam-devel@lists.sourceforge.net M +2 -0 digikamapp.cpp 1.75 M +18 -2 digikamview.cpp 1.24 M +1 -0 digikamview.h 1.16 --- kdeextragear-3/digikam/digikam/digikamapp.cpp #1.74:1.75 @@ -633,4 +633,6 @@ void DigikamApp::slotCameraConnect() ctype->port(), ctype->path()); cgui->show(); + connect(cgui, SIGNAL(signalLastDestionation(const KURL&)), + mView, SLOT(slotSelectAlbum(const KURL&))); } } --- kdeextragear-3/digikam/digikam/digikamview.cpp #1.23:1.24 @@ -234,4 +234,20 @@ void DigikamView::getForwardHistory(QStr } +void DigikamView::slotSelectAlbum(const KURL &url) +{ + if(url.isEmpty()) + return; + + Album *album = mAlbumMan->findPAlbum(url); + if(album && album->getViewItem()) + { + AlbumFolderItem *item; + item = static_cast<AlbumFolderItem*>(album->getViewItem()); + mFolderView->setSelected(item); + mParent->enableAlbumBackwardHistory(!mAlbumHistory->isBackwardEmpty()); + mParent->enableAlbumForwardHistory(!mAlbumHistory->isForwardEmpty()); + } +} + // ---------------------------------------------------------------- --- kdeextragear-3/digikam/digikam/digikamview.h #1.15:1.16 @@ -87,4 +87,5 @@ public slots: void slotAlbumHistoryForward(int steps=1); void slotAlbumDeleted(Album *album); + void slotSelectAlbum(const KURL &url); // Tag action slots Le 27 Novembre 2004 13:09, Joern Ahrens a écrit : > After closing the cameragui, the last destination is opened in digikam. > Hope you can live with that, Guillaume. I am pretty sure my father will appreciate that feature. And by the way, I saw a typo in your code : > + connect(cgui, SIGNAL(signalLastDestionation(const KURL&)), > + mView, SLOT(slotSelectAlbum(const KURL&))); signalLastDestionation should be signalLastDestination. The "o" between "Desti" and "nation" should be removed :-) Guillaume Pratte CVS commit by jahrens: Sure :-) Thanks copy and paste there was no compile error and I couldn't find it during my tests. Thanks! CVS_SILENT: corrected typo CCBUG: 92884 M +1 -1 digikam/digikamapp.cpp 1.76 M +1 -1 utilities/cameragui/cameraui.cpp 1.31 M +1 -1 utilities/cameragui/cameraui.h 1.17 --- kdeextragear-3/digikam/digikam/digikamapp.cpp #1.75:1.76 @@ -633,5 +633,5 @@ void DigikamApp::slotCameraConnect() ctype->port(), ctype->path()); cgui->show(); - connect(cgui, SIGNAL(signalLastDestionation(const KURL&)), + connect(cgui, SIGNAL(signalLastDestination(const KURL&)), mView, SLOT(slotSelectAlbum(const KURL&))); } --- kdeextragear-3/digikam/utilities/cameragui/cameraui.cpp #1.30:1.31 @@ -247,5 +247,5 @@ void CameraUI::closeEvent(QCloseEvent* e { if(!m_lastDestURL.isEmpty()) - emit signalLastDestionation(m_lastDestURL); + emit signalLastDestination(m_lastDestURL); delete m_controller; --- kdeextragear-3/digikam/utilities/cameragui/cameraui.h #1.16:1.17 @@ -130,5 +130,5 @@ private slots: signals: - void signalLastDestionation(const KURL&); + void signalLastDestination(const KURL&); }; Problem still here in digikam 0.9.3 ! |