Summary: | Settings dialog doesn't update on timer change | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | George Staikos <staikos> |
Component: | ui | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
George Staikos
2004-11-07 21:12:07 UTC
On my machine at least the event is triggered when the focus leaves the timer edit field. On Sunday 07 November 2004 18:59, Andrew Walker wrote:
> ------- On my machine at least the event is triggered when the focus leaves
> the timer edit field.
Exactly - that's not really acceptable because users don't focusout if they
don't need to.
But if they change the value by typing they have no option but to focus out
if they want to close the dialog or hit Apply. This will obviously be
confusing as they initially sit there wondering how they hit Apply on a
disabled button, but as soon as they move out of the timer edit field the
Apply button will be enabled. Ideal? - no. Workable? - yes.
------- Additional Comments From staikos kde org 2004-11-08 12:49 -------
On Sunday 07 November 2004 18:59, Andrew Walker wrote:
> ------- On my machine at least the event is triggered when the focus leaves
> the timer edit field.
Exactly - that's not really acceptable because users don't focusout if they
don't need to.
On Monday 08 November 2004 12:07, Andrew Walker wrote:
> ------- But if they change the value by typing they have no option but to
> focus out if they want to close the dialog or hit Apply. This will
> obviously be confusing as they initially sit there wondering how they hit
> Apply on a disabled button, but as soon as they move out of the timer edit
> field the Apply button will be enabled. Ideal? - no. Workable? - yes.
No, they click on some other control (checkbox) and then click on it again.
This is a downright silly situation, and it's not hypothetical. This is
actually happening. People click into the spinbox, type in their number,
then try to click Apply.
(Note: I've spent more time writing email about this than it would have taken
to fix it now.)
CVS commit by staikos: - return from main - update dirty flag on timer change CCBUG: 92876 M +1 -0 kstsettingsdlg.ui.h 1.12.2.1 M +3 -2 main.cpp 1.90.2.1 --- kdeextragear-2/kst/kst/kstsettingsdlg.ui.h #1.12:1.12.2.1 @@ -22,4 +22,5 @@ void KstSettingsDlg::init() } _apply->setEnabled(false); + connect(_timer->child("qt_spinbox_edit"), SIGNAL(textChanged(const QString&)), this, SLOT(setDirty())); } --- kdeextragear-2/kst/kst/main.cpp #1.90:1.90.2.1 @@ -412,5 +412,6 @@ int main(int argc, char *argv[]) { if (!tlv) { - exit(0); // FIXME: can cause crashes + kdError() << i18n("Can't create a view.") << endl; + return 0; } @@ -700,5 +701,5 @@ int main(int argc, char *argv[]) { args->clear(); delete kst; - exit(0); + return 0; } else { args->clear(); CVS commit by staikos: Merged HFI branch. Contains i18n changes, but po files have been extracted for 1.0 already. Hopefully I haven't made too many mistakes.... BUG: 92868, 92876 M +8 -0 curvedialog.ui 1.21 M +5 -1 curveplacementwidget.ui 1.21 M +3 -1 datamanager.ui 1.17 M +9 -0 datarangewidget.ui 1.12 M +1 -1 datawizard.ui 1.65 M +6 -6 debugdialog.ui 1.13 M +13 -30 eqdialog.ui 1.30 M +11 -4 eventmonitor.ui 1.24 M +6 -0 hsdialog.ui 1.26 M +17 -0 imagedialog.ui 1.16 M +30 -1 kst.cpp 1.258 M +10 -1 kst.h 1.114 M +87 -39 kst2dplot.cpp 1.301 M +5 -1 kst2dplot.h 1.125 M +8 -8 kstdatacollection-gui.cpp 1.11 M +14 -0 kstdatamanager_i.cpp 1.89 M +2 -0 kstdatamanager_i.h 1.29 M +30 -8 kstdoc.cpp 1.137 M +9 -7 ksthistogram.cpp 1.36 M +3 -0 kstplugin.cpp 1.79 M +1 -0 kstplugindialog_i.cpp 1.96 M +6 -2 kstrvector.cpp 1.66 M +69 -30 kstsettingsdlg.ui 1.18 M +1 -0 kstsettingsdlg.ui.h 1.13 M +3 -0 kstvcurve.h 1.28 M +12 -6 kstviewobject.cpp 1.100 M +2 -0 kstviewobject.h 1.82 M +5 -3 main.cpp 1.91 M +10 -0 matrixdialog.ui 1.11 M +7 -0 pluginmanager.ui 1.14 M +6 -0 psddialog.ui 1.27 M +4 -1 scalarselector.ui.h 1.10 M +3 -3 updatethread.cpp 1.32 M +4 -0 vectordialog.ui 1.32 M +4 -1 vectorselector.ui.h 1.8 M +4 -1 extensions/elog/elog.cpp 1.18 M +6 -0 extensions/elog/elogentry_i.cpp 1.7 M +2 -0 extensions/elog/elogentry_i.h 1.5 Change version to 1.x |