Bug 92608

Summary: It is hard to understand how 'autosave' works from export to graphics file.
Product: [Applications] kst Reporter: Netterfield <netterfield>
Component: uiAssignee: kst
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.x   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Netterfield 2004-11-02 21:17:55 UTC 
Version:           1.0.0_pre1 (using KDE 3.3.0, Gentoo)
Compiler:          gcc version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
OS:                Linux (i686) release 2.6.8-gentoo-r3

The export to graphics file dialog has an autosave checkbox and a 'save every ??s' entry. If you check them, nothing happens, until you press 'save once' in which case, it appears to start saving.

The button labels should be changed to 'OK' and 'Cancel' and the 'OK' button should also close the window.
Comment 1 Andrew Walker 2004-11-03 01:47:39 UTC 
I'm not able to reproduce this problem. If I check autosave then it starts autosaving, assuming I've given a valid folder name and have a window open.
Comment 2 Netterfield 2004-11-03 02:06:18 UTC 
I concur... it is saving once checked. (Hmmm... I wonder how I missed that?  
Well I was confused in any case, and I was responsible for the behavior in 
the first place IIRC....)

I wonder if an 'apply ok cancel' scheme would be better.  It is unusual to 
have a check box do something before 'apply' or 'ok', and there is no apply 
or ok.

thoughts?
Comment 3 Andrew Walker 2004-11-03 02:13:34 UTC 
For such a simple dialog I don't think its necessary.
i.e. if you set something incorrectly its easy to set
it back. For more complex dialogs I would agree that
OK/Cancel is nicer.
Comment 4 Netterfield 2004-11-03 02:43:23 UTC 
The current dialog works fine.  They question is whether it is consistent, and 
therefore easy to understand.
Comment 5 Andrew Walker 2004-11-03 19:11:28 UTC 
Barth,

There are arguments on both sides. I would suggest you simply make a call.
Either withdraw it or let me know and I'll modify it (though this will need i18n changes
so I guess it'll have to wait).
Comment 6 Netterfield 2004-11-03 19:20:08 UTC 
Lets decide what to do post 1.0.
Comment 7 Andrew Walker 2004-11-04 04:10:08 UTC 
Not for this release.
Comment 8 Netterfield 2004-11-29 23:10:33 UTC 
CVS commit by netterfield: 

BUG: 92608

Rework graphicsfiledialog.


  M +155 -118  graphfiledialog.ui   1.10
  M +1 -1      kst.cpp   1.259
  M +5 -2      kstdoc.cpp   1.138
  M +87 -153   kstgraphfiledialog_i.cpp   1.17
  M +28 -19    kstgraphfiledialog_i.h   1.12
  M +2 -1      updatethread.cpp   1.33