Bug 91545

Summary:	'Slideshow' does nothing if an album only contains subalbums, but no images directly or is empty
Product:	[Applications] digikam	Reporter:	Michał Kosmulski <michal>
Component:	Plugin-Generic-Presentation	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:	0.1.0
Sentry Crash Report:
Attachments:	Bug 91545: 'Slideshow' does nothing if an album only contains subalbums, but no images directly or is empty digikam slideshow does not show pics in subfolder 2006-10-03 in Album Gronau Popmuseum

Description Michał Kosmulski 2004-10-17 21:27:47 UTC

Version:           0.7 beta 1 (using KDE KDE 3.3.0)
Compiler:          gcc 3.3.4 
OS:                Linux

If Tools->Slideshow is selected and current album only contains subalbums, but no images directly in the top level album, nothing happens, as if the album was empty. Expected behavior is to create a slideshow with all images contained within the album directly (if there are any) and that album's subalbums (even if there are no images in the top-level album). This should be the same for tags, but only if 'show items in sub-tags' is enabled in the configuration dialog.
By the way, I think a dialog box should be displayed, explaining that there are no images to be shown if the album is empty. If nothing happens after clicking OK in a dialog box, the  user can get confused, even if the cause seems obvious (lack of images to show).

Comment 1 Renchi Raju 2004-10-18 02:57:06 UTC

fixed in cvs. the slideshow action is disabled if there are images in the current album. also the "show selected images only" option is disabled if there are no selected images in the current album.

regarding the first part of your bugreport, concerning items to be shown from subalbums also, the current design of kipi doesn't support this. there is no support for hierarchial albums in libkipi (note to other kipi developers: this  needs to be addressed in the second iteration of libkipi)

Comment 2 Stefan Mueller 2006-04-22 12:15:36 UTC

It would be great to get recursive sildeshow via kipi, so I can view Digikam-created subfolders in one session.

Comment 3 Stefan Mueller 2006-04-29 10:18:58 UTC

please reopen.

Comment 4 Michał Kosmulski 2006-04-29 13:07:52 UTC

here you are

Comment 5 drajar 2006-09-11 20:56:18 UTC

Created attachment 17726 [details]
Bug 91545: 'Slideshow' does nothing if an album only contains subalbums, but no images directly or is empty

When you select Show all images in current album, slideshow will show all
images from current album and subalbums.

Comment 6 caulier.gilles 2006-09-11 21:25:19 UTC

patch sound good. Thanks Drajar.

Angelo, i let's you manage this patch for the next release.

Gilles

Comment 7 Angelo Naselli 2006-09-15 23:27:51 UTC

Alle 21:25, luned

Comment 8 drajar 2006-09-19 09:54:08 UTC

Yes. I use digikam and kimdaba.

Comment 9 Angelo Naselli 2006-09-19 10:38:53 UTC

> Yes. I use digikam and kimdaba.

Thanks, only because i cannot do a lot of test in these days...

Angelo (who's going to release your patch soon)

Comment 10 Angelo Naselli 2006-09-19 11:43:07 UTC

SVN commit 586270 by anaselli:

patch provided by  drajar <djarca73 at yahoo dot com>
Tested by Gilles 
BUG: 91545

 M  +10 -0     plugin_slideshow.cpp  


--- trunk/extragear/libs/kipi-plugins/slideshow/plugin_slideshow.cpp #586269:586270
@@ -187,7 +187,17 @@
     if (showSelectedFilesOnly)
         urlList = interface->currentSelection().images();
     else
+    {
+        KURL currentPath = interface->currentAlbum().path();
+        QValueList<KIPI::ImageCollection> albumList;
+        albumList = interface->allAlbums();
+        QValueList<KIPI::ImageCollection>::iterator it;
+
         urlList = interface->currentAlbum().images();
+        for ( it = albumList.begin(); it != albumList.end(); ++it )
+            if (currentPath.isParentOf((*it).path()) && !((*it).path() == currentPath))
+                urlList += (*it).images();
+    }
 
     if ( urlList.isEmpty() )
     {

Comment 11 Stefan Mueller 2006-12-30 11:13:36 UTC

Created attachment 19068 [details]
digikam slideshow does not show pics in subfolder 2006-10-03 in Album Gronau Popmuseum