Bug 91451

Summary:	'delete' should use trashcan icon when 'delete moves to trash' is enabled
Product:	[Applications] digikam	Reporter:	Michał Kosmulski <michal>
Component:	Usability-Ergonomy	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:	7.6.0

Description Michał Kosmulski 2004-10-16 16:41:35 UTC

Version:           0.7 beta 1 (using KDE KDE 3.3.0)
Installed from:    Slackware Packages
Compiler:          gcc 3.3.4 
OS:                Linux

It is nice that digikam adds the option to move files to trash when 'Delete' is selected from the menu, but at this moment, the menu item name and icon as well as the confirmation dialog box don't say which way of deleting is selected. If 'delete should move to trash' is enabled, menus should change correspondingly: the menu item should be called 'Move to trash' and the trash icon be used instead of 'delete' icon. The confirmation dialog box should also clearly indicate, which action is going to take place, otherwise it is confusing (and can even be dangerous, if the user thinks they're confirming just moving to trash and in reality they are confirming real delete, which can't be undone).

Comment 1 Renchi Raju 2004-10-18 05:40:07 UTC

CVS commit by pahlibar: 


* update menu/toolbar text and icon everywhere dynamically according to user setting for
  "trash" or "delete" setting
* the confirmation dialog is not shown for moving to trash (konqueror behavior),
  unless an album has subalbums
GUI: confirmation for moving to trash option has been removed from settings (Miscellaneous)
CCMAIL: 91451-done@bugs.kde.org


  M +28 -15    digikam/albumfolderview.cpp   1.51
  M +13 -8     digikam/albumiconview.cpp   1.88
  M +0 -18     digikam/albumsettings.cpp   1.22
  M +0 -3      digikam/albumsettings.h   1.17
  M +24 -1     digikam/digikamapp.cpp   1.64
  M +1 -0      digikam/digikamapp.h   1.24
  M +33 -19    utilities/imageeditor/imagewindow.cpp   1.45
  M +2 -2      utilities/imageeditor/imagewindow.h   1.22
  M +0 -25     utilities/setup/setupmisc.cpp   1.4
  M +0 -7      utilities/setup/setupmisc.h   1.4