Bug 91409

Summary:	appends blank line often when using return as send shortcut
Product:	[Unmaintained] kopete	Reporter:	Rodney Gordon II <meff>
Component:	Chat Window	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	d.mills-kde, des
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Rodney Gordon II 2004-10-15 20:10:23 UTC

Version:            (using KDE KDE 3.3.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Very often while using Kopete with the send shortcut as 'Return' it often sends a blank line, before what I type on the next message, and I am not completely sure why. I only hit the return key once, but it seems to carry it over to the next message I send as well as sending the message.

Comment 1 Olivier Goffart 2004-10-17 12:43:24 UTC

I also uses Return as shortcut to send.
Anyway, it does not appends,  or only if i press on return verry long times.

Comment 2 Richard Smith 2004-11-08 22:28:34 UTC

Check your keyboard repeat rate.

Comment 3 Rodney Gordon II 2007-03-01 23:45:29 UTC

This is still happening to this date.

Debian sid, KDE 3.5.5 w/ Kopete 0.12.3

I can explain it a little more, though, perhaps this will help.

When I type in a message, and then hold down "Enter" to send it, I usually hold it down a little longer than most people I guess, because the start of my next message is a blank line and I end up sending a blank line with what I type for the next message, or I have to manually remove that line that Kopete created.

I do not have this problem with Gaim, which works as intended, so I am reopening this in hopes that it will get resolved.

-r

Comment 4 Philip Rodrigues 2007-03-11 12:40:59 UTC

The behaviour described in comment 3 is still true in 0.12.4. I suppose it's a bug, but a minor one.

Comment 5 Philip Rodrigues 2007-03-12 18:16:59 UTC

Actually, the basic issue is this: if the input line is empty, pressing Enter inserts a blank line, even if Enter is assigned to "send message". 

Perhaps related to bug 142877

Comment 6 Josh Berry 2008-07-07 06:05:09 UTC

Confirmed in trunk r828808.

The first time I press Enter in an empty input line, a blank line is inserted.

The second time, it does nothing.  (I would expect it to Send.)

Comment 7 David Mills 2009-05-26 21:57:01 UTC

I've submitted a patch to the review board concerning this bug.

Comment 8 Roman Jarosz 2009-07-25 19:06:13 UTC

SVN commit 1002323 by rjarosz:

Fix bug 91409: An empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long.
Patch by David Mills, thanks! 

BUG: 91409
CCMAIL: d.mills-kde@guesny.net



 M  +11 -1     kopetechatwindow.cpp  
 M  +3 -0      kopetechatwindow.h  
 M  +20 -6     kopeterichtextwidget.cpp  
 M  +1 -0      kopeterichtextwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002323

Comment 9 Roman Jarosz 2009-07-25 19:07:16 UTC

SVN commit 1002325 by rjarosz:

Backport fix for bug 91409: An empty line is sometimes inserted at the start of a message if the type holds down the enter key for too long.
Patch by David Mills, thanks!

CCBUG: 91409
CCMAIL: d.mills-kde@guesny.net



 M  +11 -1     kopetechatwindow.cpp  
 M  +3 -0      kopetechatwindow.h  
 M  +20 -6     kopeterichtextwidget.cpp  
 M  +1 -0      kopeterichtextwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1002325