Bug 91327

Summary:	Default margin for header in html4.css
Product:	[Applications] konqueror	Reporter:	Yan Morin <yansanmo.site>
Component:	khtml	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Yan Morin 2004-10-14 17:43:07 UTC

Version:            (using KDE Devel)
Installed from:    Compiled sources

As the exemple http://www.w3.org/TR/CSS2/sample.html
or in the res/html.css of Mozilla, 
h1, h2, h3, h4, h5, h6 should have margin-left and margin-right set to 0 by default, and font-size should respect the same sample file.

file: /kdelibs/khtml/css/html4.css

H1 {
	display: block;
	font-size: 2em;
	margin: .67__qem 0 .67em 0;
	font-weight: bolder;
}

H2 {
	display: block;
	font-size: 1.5em;
	margin: .83__qem 0 .83em 0;
	font-weight: bolder;
}

H3 {
	display: block;
	font-size: 1.17em;
	margin: 1__qem 0 1em 0;
	font-weight: bolder;
}

H4 {
	display: block;
	margin: 1.33__qem 0 1.33em 0;
	font-weight: bolder;
}

H5 {
	display: block;
	font-size: .83em;
	margin: 1.67__qem 0 1.67em 0;
	font-weight: bolder;
}

H6 {
	display: block;
	font-size: .67em;
	margin: 2.33__qem 0 2.33em 0;
	font-weight: bolder;
}

Comment 1 Stephan Kulow 2004-10-14 21:49:36 UTC

Can you name a test case where it would matter if the margin is 0 or auto?

Comment 2 Yan Morin 2004-10-14 22:51:51 UTC

------- Additional Comments From coolo kde org  2004-10-14 21:49 -------
Can you name a test case where it would matter if the margin is 0 or
auto?

When you put a width to the h1, it will be centered in Khtml and at left
in Firefox because, a block with a width and margin: 0 auto is
centered...

A block with a width without margin-left:auto and margin-right auto
isn't centered...

Comment 3 Stephan Kulow 2004-10-15 07:46:00 UTC

CVS commit by coolo: 

fixing the default margins for H{1-6} as they are in mozilla, IE and safari
CCMAIL: 91327-done@bugs.kde.org


  M +6 -6      html4.css   1.134


--- kdelibs/khtml/css/html4.css  #1.133:1.134
@@ -137,5 +137,5 @@
         display: block;
         font-size: 1.7em;
-        margin: .67__qem auto .67em auto;
+        margin: .67__qem 0 .67em 0;
         font-weight: bolder;
 }
@@ -144,5 +144,5 @@
         display: block;
         font-size: 1.4em;
-        margin: .83__qem auto .83em auto;
+        margin: .83__qem 0 .83em 0;
         font-weight: bolder;
 }
@@ -151,5 +151,5 @@
         display: block;
         font-size: 1.17em;
-        margin: 1__qem auto 1em auto;
+        margin: 1__qem 0 1em 0;
         font-weight: bolder;
 }
@@ -157,5 +157,5 @@
 H4 {
         display: block;
-        margin: 1.33__qem auto 1.33em auto;
+        margin: 1.33__qem 0 1.33em 0;
         font-weight: bolder;
 }
@@ -164,5 +164,5 @@
         display: block;
         font-size: .83em;
-        margin: 1.67__qem auto 1.67em auto;
+        margin: 1.67__qem 0 1.67em 0;
         font-weight: bolder;
 }
@@ -171,5 +171,5 @@
         display: block;
         font-size: .67em;
-        margin: 2.33__qem auto 2.33em auto;
+        margin: 2.33__qem 0 2.33em 0;
         font-weight: bolder;
 }