Bug 91217

Summary:	RMB click on album does not give the album the selection focus
Product:	[Applications] digikam	Reporter:	Achim Bohnet <ach>
Component:	Usability-Menus	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:

Description Achim Bohnet 2004-10-13 04:21:22 UTC

Version:           cvs (using KDE KDE 3.2.3)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Clicking with the RMB on a album does not give the album the
selection focus (RMB does not make it the 'current' album).
So it's not clear
if the RMB menu action apply to the album below the mouse
or the current menu that had the selection focus before the
RMB click.

Opening the properties dialog, uncovers that the album below
the mouse is used but this is different from how kmail, konqueror
file browser of kdesktop handle RMB clicks.  All give the item
clicked with the RMB the selection focus.

Achim

Comment 1 Renchi Raju 2004-10-13 04:53:24 UTC

CVS commit by pahlibar: 


mouse button press, instead of release, will select the item. also do it for
right mouse button press.
CCMAIL: 91217-done@bugs.kde.org


  M +2 -2      listview.cpp   1.10


--- kdeextragear-3/digikam/digikam/listview.cpp  #1.9:1.10
@@ -356,4 +356,6 @@ void ListView::contentsMousePressEvent(Q
         return;
 
+    setSelected(item);
+
     if (e->button() == Qt::RightButton) {
         emit signalRightButtonPressed(item);
@@ -377,6 +379,4 @@ void ListView::contentsMouseReleaseEvent
         }
     }
-
-    setSelected(item);
 }

Comment 2 Achim Bohnet 2004-10-13 13:51:21 UTC

Hi Renchi,
thx for the fix.

FWIW kdesktop, kmail, konqueror activate the action of a LMB on
release not on mouse press.

Comment 3 Michał Kosmulski 2004-10-17 21:41:51 UTC

For tags, this new behavior is inconvenient, at least for me. Common situation is that I'm tagging an album and realize that a new tag needs to be created. So I right-click some tag to create a sub-tag and I can create it, but that tag is opened and I am taken out of my initial album. So after adding the new tag I have to go back to my album, find the last image that was tagged and only then can I continue. Perhaps right-click should select albums, but not tags. See also bug #91540.