Summary: | Support for "Part of a set" (TPOS) ID3v2 frame | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Ilya Konstantinov <kde-bug-report> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | chkr, cruff, jann.ove, kjetilho, nicolas.girard, uspoerlein |
Priority: | NOR | ||
Version: | 1.1 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | support for composer/dicsnumber tags in flac files |
Description
Ilya Konstantinov
2004-09-29 21:44:29 UTC
*** This bug has been confirmed by popular vote. *** *** Bug 108235 has been marked as a duplicate of this bug. *** *** Bug 111354 has been marked as a duplicate of this bug. *** FLAC and Vorbis files commonly have "DISC" and "DISCNUMBER" tags for the same purpose. There's good discussion of how they can be useful at http://www.hydrogenaudio.org/forums/lofiversion/index.php/t31872.html and I'd like to request grouping discs together, preferably by "DISCNUMBER" first and "DISC" after, for maximum flexibility per that discussion. (See the example about Enya's "A Box Of Dreams" set.) *** Bug 109903 has been marked as a duplicate of this bug. *** SVN commit 490984 by aoliveira: Support for Composer and Disc Number tags, for mp3 (id3v2) and ogg vorbis. They show up on tagdialog, and can be use as playlist columns. MetaBundle is now also used to save tag changes, to avoid code duplication (as there's code to handle these extra tags). Collection Scanner also uses tag dialog, to be able to use these tags as well. Collection version bumped, rescan required. BUG: 110675 BUG: 90503 M +2 -0 ChangeLog M +21 -8 src/collectiondb.cpp M +4 -2 src/collectiondb.h M +1 -0 src/collectionscanner/Makefile.am M +18 -25 src/collectionscanner/collectionscanner.cpp M +138 -5 src/metabundle.cpp M +35 -5 src/metabundle.h M +48 -41 src/playlist.cpp M +27 -1 src/playlistitem.cpp M +16 -0 src/playlistitem.h M +3 -1 src/scancontroller.cpp M +34 -44 src/tagdialog.cpp M +6 -0 src/tagdialog.h M +138 -76 src/tagdialogbase.ui M +1 -1 src/tagguesser.cpp Created attachment 14161 [details]
support for composer/dicsnumber tags in flac files
I know it has been marked as resolved but I believe that flac files should be
also supported here. At least I missed it much.
The patch is attached. I don't claim its perfect and maybe I missed something
(I don't know amarok project at all). But it works for me so maybe you'll find
it usefull too.
|