Bug 89844

Does it make sense to never update data sources when Kst is paused?  if so, that would be the fix.  However just not updating on plot dialog changes is rather broken by design.  The problem is deciding what should and should not be updated, and basically I think we can define it to when should all objects be updated, and when should all objects except rvectors be updated.  Until this is decided, I can't really fix this bug.

Well, here's the case I was coming from:  
Looking at live data.  Something interesting happens, and I want to print or export to an image, but first I want to make some cosmetic changes (change label text or plot colors or something).  I hit pause, edit the plots attributes, apply edits, and because new data is loaded, the 'interesting' event is gone.

I think that 'pause' should produce prohibit updating of data-sources (even with force set), but should allow everything else to behave as if 'pause' were not set.

This would mean that plot edits, adding curves, range changes get updated, but no new data gets noticed until pause is unset.  Of course this would prohibit even manually trying to look at new data, but I think that is OK.

CVS commit by staikos: 

Does this solve the update issues?  If so, are there any conceivable cases
where we would still want to be able to force an update of data sources?

CCMAIL: 89844@bugs.kde.org


  M +12 -10    updatethread.cpp   1.28


--- kdeextragear-2/kst/kst/updatethread.cpp  #1.27:1.28
@@ -138,4 +138,5 @@ bool UpdateThread::doUpdates(bool force,
 
   // Update the files
+  if (!_paused) { // don't update even if paused && force
   KST::dataSourceList.lock().readLock();
   unsigned cnt = KST::dataSourceList.count();
@@ -145,5 +146,5 @@ bool UpdateThread::doUpdates(bool force,
     dsp->update();
 
-    if (_done || (_paused && !force)) {
+      if (_done) {
       KST::dataSourceList.lock().readUnlock();
 #if UPDATEDEBUG > 1
@@ -154,4 +155,5 @@ bool UpdateThread::doUpdates(bool force,
   }
   KST::dataSourceList.lock().readUnlock();
+  }
 
   { // scope to destroy the temporary list

This doesn't quite solve all the issues.  My test case: Looking at live data; paused.  Open edit plots, and edit the legend (I just alternate between show and disable), clicking on apply edits to see if the plots update (ie legend appears and disappears) and the curves do not.  

Right now, the first few times I click apply edits, the curves will update, and then after that, they will not.  Few is random, and is usually between 1 and 5.  Once the curves stop updating, I can close and reopen the edit plot dialog and make changes and the curves don't update.  If I unpause and re-pause, the process starts over.  

Sorry, can't reproduce this anymore.  If you still have a problem, please reopen it with more detail. #5 definitely can't be reproduced.