Bug 89579

Summary:	delete on "association name" label makes umbrello crash
Product:	[Applications] umbrello	Reporter:	Roberto Rambaldi <Roberto.Rambaldi>
Component:	general	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	crash	CC:	robin.snyder
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Test case which crashes Umbrello without crash report when selecting assoc label and pressing delete. fix for the crash on deleting an association label

Description Roberto Rambaldi 2004-09-15 17:56:51 UTC

Version:           1.3.0 (using KDE 3.2.1, SuSE)
Compiler:          gcc version 3.3.3 (SuSE Linux)
OS:                Linux (i686) release 2.6.7-ck1

In state diagram put a state, then another and draw an association
set the association name then click on the association name label
and hit the "del" key. Umbrello starts allocating memory and hangs the
machine.

Comment 1 Pekka Jääskeläinen 2004-09-17 13:24:57 UTC

Created attachment 7559 [details]
Test case which crashes Umbrello without crash report when selecting assoc label and pressing delete.

The crash happens also (at least) in class diagram. The point is to select the
label of association not the association itself to produce the crash. It causes
segmentation fault printed to the console, no KDE crash report.

Comment 2 Pekka Jääskeläinen 2004-09-20 00:57:39 UTC

Created attachment 7584 [details]
fix for the crash on deleting an association label

This patch should fix the crash. It's against the CVS HEAD. I will test it
thoroughly later.

Comment 3 Jonathan Riddell 2004-09-20 19:22:12 UTC

Great, I've commited your fix, many thanks.

Please put this in ~/.cvsrc to create the most easy to use diffs

cvs -l -q -z4
diff -up
update -dP
checkout -P

Thanks again

Comment 4 Jonathan Riddell 2004-09-25 00:28:55 UTC

*** Bug 88233 has been marked as a duplicate of this bug. ***

Comment 5 Cengiz Gunay 2004-09-30 21:38:13 UTC

Same memory allocation related system crash is caused by deleting associations in collaboration diagrams. This patch only fixed the problem in the state diagram for me.

Comment 6 Oliver Kellogg 2004-10-02 04:42:17 UTC

Could you try again?
I found another occurrence of deletion before UMLDoc::setModified()
which I fixed.

Comment 7 Jonathan Riddell 2004-10-12 23:21:46 UTC

Collaboration diagrams work for me (although there is still the curious issue of a strange initial name starting with 'm').

Comment 8 Roberto Rambaldi 2004-10-21 17:49:10 UTC

sorry, up to now I cannot test it because I have problems in compiling the cvs version, I'll let you know as I solve the compilation problem

Comment 9 Lars Plessmann 2006-11-28 00:33:09 UTC

Same problem occurs on my opensuse system.
I compiled umbrello 1.5.52 without any failure.

When I run the application and try to delete a role label, it crashes and stats to run a endless loop. I see the following output on my console:

umbrello: UMLView::addWidget (modified_by type=313): position (0,0) is out of range.

Its serious, becaust it occurs only when I try to delete some labels one by one.
At around the 6th label it starts the error loop and crashes.