Bug 89265

CVS commit by carewolf: 

I appear to be wrong in assuming samplingRate will never be 0.
CCMAIL:89265-done@bugs.kde.org


  M +2 -1      akodePlayObject_impl.cpp   1.18.2.3


--- kdemultimedia/akode/arts_plugin/akodePlayObject_impl.cpp  #1.18.2.2:1.18.2.3
@@ -231,5 +231,6 @@ poTime akodePlayObject_impl::currentTime
         pos = decoder->position();            // decoder time
         if (pos < 0 ) pos = 0;
-        else {
+        else
+        if (samplingRate > 0) {
             float lpos = (float)(buf_pos-buffer->length) / (float)samplingRate;  // local time
             pos += (long)(lpos*1000.0);

Latest CVS kdelibs, kdemultimedia, kdeaddons, from KDE_3_3_BRANCH. It crashes again:

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 2101)]
[New Thread 32769 (LWP 2108)]
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 2101)]
[New Thread 32769 (LWP 2108)]
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 2101)]
[New Thread 32769 (LWP 2108)]
[New Thread 65538 (LWP 2169)]
[KCrash handler]
#4  0x40b79e99 in akodePlayObject_impl::currentTime (this=0x80dc5f0)
    at akodePlayObject_impl.cpp:235
#5  0x400ab2dc in _dispatch_Arts_PlayObject_05 (object=0x80dc6a0, 
    result=0x80e4ef0) at kmedia2.cc:489
#6  0x404ecf10 in Arts::Object_skel::_dispatch (this=0x80dc6a8, 
    request=0x80a2eb8, result=0x80e4ef0, methodID=22) at object.cc:850
#7  0x404dff0c in Arts::Dispatcher::handle (this=0xbffff6f0, conn=0x80dc8f0, 
    buffer=0x80a2eb8, messageType=4) at dispatcher.cc:560
#8  0x404af3f5 in Arts::Connection::receive (this=0x80dc8f0, 
    newdata=0xbfffd3e0 "MCOP", newlen=24) at connection.cc:168
#9  0x404f3f97 in Arts::SocketConnection::notifyIO (this=0x80dc8f0, _fd=10, 
    types=1) at socketconnection.cc:139
#10 0x404e762b in Arts::StdIOManager::processOneEvent (this=0x807eda8, 
    blocking=true) at iomanager.cc:308
#11 0x404e7849 in Arts::StdIOManager::run (this=0x807eda8) at iomanager.cc:357
#12 0x404e16cc in Arts::Dispatcher::run (this=0xbffff6f0) at dispatcher.cc:955
#13 0x0806937b in main (argc=14, argv=0xbffff814) at artsd.cc:360

CVS commit by carewolf: 

Fix segfault when currentPosition() is called right between loadMedia() and play().
CCMAIL: 89265-done@bugs.kde.org


  M +1 -1      akodePlayObject_impl.cpp   1.18.2.4


--- kdemultimedia/akode/arts_plugin/akodePlayObject_impl.cpp  #1.18.2.3:1.18.2.4
@@ -232,5 +232,5 @@ poTime akodePlayObject_impl::currentTime
         if (pos < 0 ) pos = 0;
         else
-        if (samplingRate > 0) {
+        if (samplingRate > 0 && buffer) {
             float lpos = (float)(buf_pos-buffer->length) / (float)samplingRate;  // local time
             pos += (long)(lpos*1000.0);

Could be useful commit this changes to HEAD too, or not? The KDE_3_3_BRANCH 
now is fixed.

----------  Messaggio inoltrato  ----------

Subject: Re: kernel header bug
Date: 21:31, luned