Bug 89057

Summary: Rich Konqueror to KMail copy/paste not implemented
Product: [Unmaintained] kmail Reporter: Gavin Hamill <gdh>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: johnflux, julian
Priority: NOR    
Version: 1.7   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Gavin Hamill 2004-09-08 11:05:44 UTC
Version:           1.7 (using KDE KDE 3.3.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Hi. 

If I open a webpage in Konqueror and Select All with CTRL-A, the whole page including images is selected. Now if I open a KMail composer window and Paste with CTRL-V, only the ASCII text from the webpage is pasted.

No formatting is preserved, and no images are embedded into the email. 

I believe this should be on the wishlist because even the elderly installations of Windows 98 and Outlook 98 at work preserve the full HTML formatting and include the images in base64 encoding embedded into the email - and this is 6-year old software :)

Cheers,
Gavin.
Comment 1 John Tapsell 2004-12-21 20:17:36 UTC
CVS commit by johnflux: 

HAPPY CHRISTMAS ALL!  My present to you all - My biggest patch yet.

When you select text and copy it to clibboard, it now retains the formatting.
It's fairly complex, so there will possibly be bugs despite my testing.
I'd really like any feedback.

It does not deal with css, so the formatting may be a little off.  I do not think I will 'fix' this as I don't see it being that broken a behaviour.  (feel free to persuade me otherwise)

It is guaranteed to produced valid xml.

When copying text+images, the images are pasted as urls (since I'm using mimetype text/html).  I'm looking at perhaps embedding the images in the clipboard using a webarchive.

You can right click an image and copying the image.  This now actually copies it to the clipboard as well.  This shows up bugs in openoffice (not dealing with transparency correctly for some reason) and kword (it prefers to paste as text/plain over image/* )
Also note that a copied image is the image you see.  Not the image downloaded.

Please note that no functionality has been removed.  Copying and pasting text to a program that does not support rich text, pastes it without formatting, exactly as it did before.  For apps that do support rich text, I strongly recommend all such apps implement 'paste special' of some sort so the user can chose to paste without formatting.  I may work on this at some point.

You can test this by pasting into openoffice.  Support for pasting into kword will come soon I hope (I need to get kword to run it's import filters on the clipboard data)



FEATURE:89057
FEATURE:36029
FEATURECC:71476


  M +1 -1      Makefile.am   1.163
  M +68 -15    khtml_ext.cpp   1.106
  M +1 -0      khtml_ext.h   1.32
  M +5 -0      khtml_part.cpp   1.1064
  M +2 -0      khtml_part.h   1.271
  M +1 -0      khtml_popupmenu.rc   1.35
  M +4 -2      dom/dom2_range.cpp   1.37
  M +2 -1      html/html_imageimpl.h   1.69
  M +185 -3    xml/dom2_rangeimpl.cpp   1.35
  M +16 -1     xml/dom2_rangeimpl.h   1.24
  M +43 -4     xml/dom_elementimpl.cpp   1.205
  M +16 -2     xml/dom_elementimpl.h   1.121
  M +12 -1     xml/dom_nodeimpl.h   1.166
  M +14 -0     xml/dom_textimpl.cpp   1.105
  M +6 -1      xml/dom_textimpl.h   1.62



Comment 2 Gavin Hamill 2004-12-21 21:10:32 UTC
John, 

You are a king among men - thank you so much for this :)

I may even try to compile KDE from CVS to try it :D

Cheers,
Gavin
Comment 3 Bartosz Malinowski 2005-06-11 10:49:24 UTC
This is great, it will probably influence my usage of Firefox, as I often like to paste some train timetables into OOo.. Many thanks for this.

Another interesting issue (especially for me, and probably for some other
non-english-speaking users as well) is the issue of encoding - the characters
in text pasted from konq to OOo, if the source website uses eg. iso-8859-2 or
is in cyrilics get somewhat altered.

greetings,
b.

Comment 4 Bartosz Malinowski 2005-06-11 11:09:54 UTC
As of Kmail 1.8.1 (kde 3.4.1) I still can't paste rich text into kmail
composer window (Mandriva 2005 LE, Thac rpms with kde). All text gets 
pasted as plain.

Cheers,
b.
Comment 5 Bartosz Malinowski 2006-06-11 13:23:48 UTC
Please reopen this bug... As of Kmail 1.9.1 (Kde 3.5.2) this bug has't been resolved. No possibility to paste any html-formatted txt (/w or without images) into Kmail composer window and severe problem with pasting iso-8859-2 encoded text without middle-european characters getting corrupted (copying from Konqueror).

b.