| Summary: | When only one tab on konsole, disable the "close tab" button, as in Konqueror | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | David Martin <tasio> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 1.4 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
CVS commit by binner: Bug 88428: When only one tab on konsole, disable the "close tab" button, as in Konqueror (wishlist) CCMAIL: 88428-done@bugs.kde.org M +3 -0 konsole.cpp 1.472.2.3 --- kdebase/konsole/konsole/konsole.cpp #1.472.2.2:1.472.2.3 @@ -886,4 +886,5 @@ void Konsole::makeTabWidget() m_removeSessionButton->setIconSet( SmallIcon( "tab_remove" ) ); m_removeSessionButton->adjustSize(); + m_removeSessionButton->setEnabled(false); connect(m_removeSessionButton, SIGNAL(clicked()), SLOT(confirmCloseCurrentSession())); tabwidget->setCornerWidget( m_removeSessionButton, BottomRight ); @@ -2397,4 +2398,5 @@ void Konsole::addSession(TESession* s) enableMasterModeConnections(); } + m_removeSessionButton->setEnabled(tabwidget->count()>1); } @@ -2838,4 +2840,5 @@ void Konsole::doneSession(TESession* s) } delete s->widget(); + m_removeSessionButton->setEnabled(tabwidget->count()>1); } session2action.remove(s); Actually, I am, and there might be other people unhappy about this. Since I am using mouse gestures which map uniquely to a keyboard shortcut, it is impossible to consistently close a Konqueror tab. One gesture will be needed when more than one tab is present, and another when only one tab is present. I use close tab gestures in konsole right now and this would worsen my experience. Mabe KDE should obtain a tab management KCM that would allow people to configure such things? Thanks! I agree with comment #2; I'm not sure blindly following Konq is correct. I would say we need a way to configure this option. The style guide says that the close tab action shouldn't close the application. |
Version: 1.4 (using KDE 3.3.0, (3.1)) Compiler: gcc version 3.3.4 (Debian 1:3.3.4-9) OS: Linux (i686) release 2.6.7 As in the subject, when we have only a tab on Konsole, the "close tab" button ("X") at the right of the tabs bar, would be disabled. It would be nice imitating Konqueror's behaviuor.