Bug 88353

Summary:	Konqueror expands %XX sequences in URLs
Product:	[Applications] konqueror	Reporter:	cb-kde
Component:	general	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	RMB popup menu provides URIs properly (?) escaped Location Bar shows escaped URIs for non-local entities

Description cb-kde 2004-08-29 02:03:50 UTC

Version:            (using KDE KDE 3.3.0)
Installed from:    Compiled From Sources
OS:                Linux

Actually using cvs from shortly after 3.3-rc2

Konqueror expands %XX sequences in URLs to the characters which are represented by the hex values. This means that the URL displayed in the Location bar is not a valid URL and the URL given by choosing 'Copy Link Address' is also not valid.

This happens anywhere with %20 (displayed as space) in the URLs. The 'details' links on the following page are one example:

http://www.wyn-thomas.co.uk/19901994.htm

Even if the URLs are displayed with spaces (arguably reasonable) features such as Copy Link Address should really present a valid URL.

Comment 1 G Sanft 2005-03-05 13:07:05 UTC

Created attachment 9979 [details]
RMB popup menu provides URIs properly (?) escaped

Comment 2 G Sanft 2005-03-05 13:07:59 UTC

Created attachment 9980 [details]
Location Bar shows escaped URIs for non-local entities

Comment 3 G Sanft 2005-03-05 13:09:20 UTC

This is silly, isn't it?  There was some discussion in http://bugs.kde.org/show_bug.cgi?id=53751 along the same lines.  That bug is not so clearly worded, but it's mostly the same topic, and it's not gone anywhere in over a year (and still classified NEW!).

I don't agree with the sentiments expressed there that escaped unsafe characters should be kept from the user's view.  I feel doing that serves to keep the users dumb.  If they're foolish enough to use blank spaces, for example, in filenames, well, at least they should not be continually encouraged to do so such that they'll never come to an understanding of what the ramifications are.

Certainly, hiding the escape sequences makes it more difficult for us who would like to select the Location Bar data for use in any myriad of standard software which doesn't have all the overhead of fixing erroneous data prior to manipulating it.  Same for the Link or Image Locations from within the RMB menus.

To that end, I've cobbled a couple of changes together against the (current) 3.4.0-rc1 code I have here.

The popup-menu-related code is commented well enough that I needn't go into it here.

The Location Bar code may very well be less elegant than it could be, but everything else I tried was inconveniently undone at the point I've inserted the changes, so that's where they are.

The changes are in two files which I'll attach:  

khtml_ext.cpp.diff (3272 bytes)
konq_mainwindow.cc.diff (679 bytes)

Comment 4 Tommi Tervo 2005-08-15 12:18:51 UTC


*** This bug has been marked as a duplicate of 53751 ***