Bug 87651

Summary:	complete tasks can't be selected
Product:	[Applications] ktimetracker	Reporter:	richard
Component:	general	Assignee:	Mark Bucciarelli <mark>
Status:	RESOLVED FIXED
Severity:	normal	CC:	airbaggins, holster
Priority:	VHI
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch to allow completed tasks to be selectable, with status icons instead of disabling Patch to allow completed tasks to be selectable, with status icons instead of disabling (revision 2)

Description richard 2004-08-21 01:09:40 UTC

Version:            (using KDE KDE 3.2.92)
Installed from:    Gentoo Packages

I marked several tasks as complete in karm to make it easier to find the ones that are still active, and now I want to delete them. There's just one problem: they can't be selected anymore! Will they be permanently stuck there if I don't edit the data file?

Comment 1 Mark Bucciarelli 2004-08-26 16:05:53 UTC

Thanks for your bug report.  Yes, they will be stuck.  :(  

You will have to edit the ics file manually.  If you use Vim, a command like:

:%s/PERCENT-COMPLETE:100/PERCENT-COMPLETE:99/

will re-enable the entries.

Comment 2 richard 2004-08-28 01:58:37 UTC

That fixed it.

Thanks for the help... and the excellent program :)

Comment 3 Bill Robinson 2005-06-05 19:41:13 UTC

Created attachment 11344 [details]
Patch to allow completed tasks to be selectable, with status icons instead of disabling

Sorry if this patch does not apply correctly, as it might depend on others I've
already made today. 

This includes two small additional icons to indicate the completeness of a
task. It allows a user to reinstate a task as incomplete, even after marked
complete. The task is no longer disabled.

Maybe the green tick is not a good idea, I don't know. It depends on your
colour scheme. Sorry if the icons are a bit uninspiring aswell.

Comment 4 Bill Robinson 2005-06-07 00:27:08 UTC

Created attachment 11361 [details]
Patch to allow completed tasks to be selectable, with status icons instead of disabling (revision 2)

Same as the previous, but correctly sets icon of new task.
Whoops. :)

Comment 5 Thorsten Staerk 2005-06-25 13:47:08 UTC

super work, I tested it and it works fine. Thanks for the patch. Your code is beautiful.

The icons do not work at me, I will have a look at it.

Comment 6 Thorsten Staerk 2005-06-25 14:28:36 UTC

SVN commit 428820 by tstaerk:

adding a patch by William Robinson to allow selecting of completed
tasks.
CCBUGS:87651


 M  +10 -1     karm_part.cpp  
 M  +1 -0      karm_part.h  
 M  +2 -14     karmstorage.cpp  
 M  +5 -0      karmui.rc  
 M  +10 -1     mainwindow.cpp  
 M  +1 -0      mainwindow.h  
 M  +2 -1      pics/Makefile.am  
 A             pics/task-complete.xpm  
 A             pics/task-incomplete.xpm  
 M  +15 -5     task.cpp  
 M  +5 -0      task.h  
 M  +34 -10    taskview.cpp  
 M  +5 -0      taskview.h

Comment 7 Thorsten Staerk 2005-06-25 14:35:24 UTC

William, I would feel honored if we could do some peer programming, maybe with Mark, the maintainer of karm. Contact kde at staerk de. Your code is in subversion now.

Comment 8 Alexander Potashev 2019-11-12 20:45:56 UTC

*** Bug 108539 has been marked as a duplicate of this bug. ***