Summary: | kio file gives confusing error message when opened file is deleted on disc | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Rinse De Vries <rinse> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | christoph, grundleborg, mattr, nicolasg |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Rinse De Vries
2004-08-20 17:57:53 UTC
As far as I know, this behaviour is part of Kate and not of kio. Have a nice day! CVS commit by alund: uninline reasonedMOHString, so that the strings gets translated :\ Backport follows CCMAIL: 87617-done@bugs.kde.org M +13 -0 katedocument.cpp 1.753 M +3 -14 katedocument.h 1.292 --- kdelibs/kate/part/katedocument.cpp #1.752:1.753 @@ -5325,4 +5325,17 @@ bool KateDocument::createDigest( QCStrin } +QString KateDocument::reasonedMOHString() const +{ + QString reason; + if ( m_modOnHdReason == 1 ) + reason = i18n("modified"); + else if ( m_modOnHdReason == 2 ) + reason = i18n("created"); + else if ( m_modOnHdReason == 3 ) + reason = i18n("deleted"); + + return i18n("The file '%1' was changed (%2) on disk by another program.").arg( url().prettyURL() ).arg( reason ); +} + void KateDocument::removeTrailingSpace( uint line ) { --- kdelibs/kate/part/katedocument.h #1.291:1.292 @@ -934,16 +934,5 @@ class KateDocument : public Kate::Docume * @since 3.3 */ - inline QString reasonedMOHString() const - { - QString reason; - if ( m_modOnHdReason == 1 ) - reason = i18n("modified"); - else if ( m_modOnHdReason == 2 ) - reason = i18n("created"); - else if ( m_modOnHdReason == 3 ) - reason = i18n("deleted"); - - return i18n("The file '%1' was changed (%2) on disk by another program.").arg( url().prettyURL() ).arg( reason ); - } + QString reasonedMOHString() const; /** I reopened the bug, Because I fail to see how this patch resolves the problem :o) Why are those error messages in such a technical way? Why not just straight ahead error messages that give the correct information about the problem? I mean not like this: The file 'hi.txt' was changed (deleted) on disk by another program" What do you want to do? |Reload File |Ignore Changes| But like this: The file 'hi.txt' was deleted on disk by another program" What do you want to do? |Restore File|Ignore Changes| The first still gives an odd option, since there is no file on disc that can be reloaded. Also, the dialog has also this option: The file 'test' was changed (Created) on disk by another program" What do you want to do? |Reload File |Ignore Changes| Now, how can another program create the file on disc if it is already there? The code is found in kdelibs/kate/part/katedocument.cpp (starting at 4443). Kind regards, Rinse sorry, i closed the wrong bug Seems to be fixed in trunk svn #767426 > George Goldberg 2008-01-28 07:54:48 UTC
> Seems to be fixed in trunk svn #767426
Then closing.
|