Bug 87536

Created attachment 7186 [details]
Archive with suggested ../templates/kdewebdev/quanta.pot

I have inserted the strings (this was the only change to the file) and testet
with msgfmt and then quanta+ with the resulting .mo, works fine.

Of course, before using msgfmt, I opened the .pot with kbabel and made a .po as the base for msgfmt, filling in the role of translators, which is then available due to the new strings.

Comment on attachment 7186 [details]
Archive with suggested ../templates/kdewebdev/quanta.pot

Changing the .pot files directly is not the way to go, as Scripty will
overwrite it the next European night.

From what I see in the file admin/cvs.sh, line 578, you need to have the 
sequence KAboutData somewhere in one *.c* file. 

(Even a hacky comment should work if nothing else is possible.)

Have a nice day!

On Monday 13 September 2004 13:36, Andras Mantia wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Monday 13 September 2004 14:34, Nicolas Goutte wrote:
> > I do not think that it has much sence to apply it, as
> > tonight/tomorrow Scripty will re-extract the files.
>
> But how why aren't those lines appear in some of the pot files, but
> appear in others??
>
> Andras
>
> > Have a nice day!
> >
> > On Monday 13 September 2004 12:57, Andras Mantia wrote:
> > > Hi,
> > >
> > >  Can someone with write access to kde-i18n/templates/kdewebdev
> > > apply this patch in order to fix bug #87536?
> > >
> > > Thanks,
> > > Andras
>
> - --
> Quanta Plus developer - http://quanta.sourceforge.net
> K Desktop Environment - http://www.kde.org
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBRYYlTQdfac6L/08RAqmaAKDi3PKAJ+MUQjrLQQnOc3HE78PkugCeKUAh
> 3IrQAixcknXOuDwCgN1DtdI=
> =c17q
> -----END PGP SIGNATURE-----

And also, as the generated file is a *.cpp file, it must be extracted too. (I 
have not checked if it is the case or not.)

Have a nice day!

On Monday 13 September 2004 16:47, Nicolas Goutte wrote:
(...)
>From what I see in the file admin/cvs.sh, line 578, you need to
> have the sequence KAboutData somewhere in one *.c* file.
>
> (Even a hacky comment should work if nothing else is possible.)
>
> Have a nice day!
>
> On Monday 13 September 2004 13:36, Andras Mantia wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Monday 13 September 2004 14:34, Nicolas Goutte wrote:
> > > I do not think that it has much sence to apply it, as
> > > tonight/tomorrow Scripty will re-extract the files.
> >
> > But how why aren't those lines appear in some of the pot files, but
> > appear in others??
> >
> > Andras
> >
> > > Have a nice day!
> > >
> > > On Monday 13 September 2004 12:57, Andras Mantia wrote:
> > > > Hi,
> > > >
> > > >  Can someone with write access to kde-i18n/templates/kdewebdev
> > > > apply this patch in order to fix bug #87536?
> > > >
> > > > Thanks,
> > > > Andras
> >
> > - --
> > Quanta Plus developer - http://quanta.sourceforge.net
> > K Desktop Environment - http://www.kde.org
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.2.4 (GNU/Linux)
> >
> > iD8DBQFBRYYlTQdfac6L/08RAqmaAKDi3PKAJ+MUQjrLQQnOc3HE78PkugCeKUAh
> > 3IrQAixcknXOuDwCgN1DtdI=
> > =c17q
> > -----END PGP SIGNATURE-----

A first check seems to tell me that Kivio is affected too, as it has not any 
code in its "topsubdir" koffice/kivio. (And Quanta seems not having code 
either in kwebdev/quanta.)

Have a nice day!

Krita seems affected too.

I think I have found why it is not recursing.

The parameter of grep is *.c* *.C*

But not any directory has such a pattern, so it will always remain at the top 
directory.

So the fix is to use find:

find . -name "*.c*" -o -name "*.h*" | grep KAboutData

That should work better!

Have a nice day!

On Monday 13 September 2004 23:46, Nicolas Goutte wrote:
> On Monday 13 September 2004 23:24, David Faure wrote:
> > On Monday 13 September 2004 23:06, Nicolas Goutte wrote:
> > > Could someone check if Kivio has bug #87536 too?
(...)
> > > And of course please also check other applications not having code in
> > > their "topsubdir". (Krita?)
> >
> > I suggest using grep -r :)
>
> H'm looking again in admin/cvs.sh (line 578) it already uses it. But then
> why it is not working?
>
> (Perhaps the *.C* in the line should be replaced by *.h* as anyway using C
> as extension is against one of the KDE policies in the meantime.)
>
> Have a nice day!
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@mail.kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel

The attached patch is for the file kde-common/admin/cvs.sh

It tries to fix the search for KAboutData in source to add the necessary i18n 
entries so that the translators can add their names and emails to the 
application translation.

Reason:
- "grep -r *.c* *.C*" would only recurse when finding directory matching that 
pattern which is not possible.

Changes:
- use *.h* as some KAboutData are only defined there.
- remove *.C* as using *.C as extension is not allowed anymore in KDE for a 
few years now.
- use -s for grep, as the first find is more than enough for us.

This should probably backported to the 2 current stable branches, 
KDE_3_3_BRANCH and KOFFICE_1_3_BRANCH. But perhaps testing it first in CVS 
HEAD would perhaps be better.

This fix is part of bug #87536 but it is not sure if this fix is sufficient 
for fixing the complete bug.

Have a nice day!


Created an attachment (id=7515)
cvs_sh.diff

(...)
> find . -name "*.c*" -o -name "*.h*" | grep KAboutData
xargs is missing! Sorry!

(...)

On Tuesday 14 September 2004 00:06, Nicolas Goutte wrote:
> The attached patch is for the file kde-common/admin/cvs.sh
> 
> It tries to fix the search for KAboutData in source to add the necessary i18n 
> entries so that the translators can add their names and emails to the 
> application translation.
> 
> Reason:
> - "grep -r *.c* *.C*" would only recurse when finding directory matching that 
> pattern which is not possible.
Well spotted.

> Changes:
> - use *.h* as some KAboutData are only defined there.
I guess KOffice is the main culprit there :)

> - remove *.C* as using *.C as extension is not allowed anymore in KDE for a 
> few years now.

Oh, even ksysguard doesn't use *.C anymore? Interesting.

Can you commit it? (I have no karma for the admin dir.)

And I have just found out that Andras Mantia <amantia@kde.org>
has already posted a very similar patch to kde-core-devel hours ago but it is 
not committed either (nor commented.)

As for *.C the problem is that in case-insensitive filesystems it gives *.c 
and that is not anymore a C++ file.

Have a nice day!

On Tuesday 14 September 2004 00:11, David Faure wrote:
> On Tuesday 14 September 2004 00:06, Nicolas Goutte wrote:
> > The attached patch is for the file kde-common/admin/cvs.sh
> >
> > It tries to fix the search for KAboutData in source to add the necessary
> > i18n entries so that the translators can add their names and emails to
> > the application translation.
> >
> > Reason:
> > - "grep -r *.c* *.C*" would only recurse when finding directory matching
> > that pattern which is not possible.
>
> Well spotted.
>
> > Changes:
> > - use *.h* as some KAboutData are only defined there.
>
> I guess KOffice is the main culprit there :)
>
> > - remove *.C* as using *.C as extension is not allowed anymore in KDE for
> > a few years now.
>
> Oh, even ksysguard doesn't use *.C anymore? Interesting.

It should be now fixed. I tested locally and every kdewebdev/*.pot file 
has the _translatorinfo.cpp entry.