Summary: | Translated named colors break the color selection (kcolorchooser) | ||
---|---|---|---|
Product: | [Unmaintained] kdelibs | Reporter: | gerard |
Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bluedzins, cfeck, gerard, lex.lists, lueck, nicolasg |
Priority: | NOR | ||
Version: | 3.3 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
gerard
2004-08-19 10:44:02 UTC
Point 5 is done (not in KDE 3.3.) Point 6 can only be done by using the rgb.txt of X.org. However putting it in kdelibs potentially creates a conflict with the licenses allowed in kdelibs. (I have not checked and I do not know exactly the X.org license (neither the old XFree one, where the file comes from.)) Have a nice day! Thanks for fixing point 5 ******** NEW Point 7: the window is not resizable. Should more comfortable to display a long list of colors, and more consistent with other KDE windows. (wish) ******** About point 6, I don't understand some things. The actual pot file contains 223 colors Kcolorchooser contains about 400 rgb.tx contains about 705 I cannot explain why rgb.txt has more entries than Kcolorchooser. I Thought Kcolorchooser took dynamically its list in rgb.txt In rgb.txt, many colors are duplicated (YellowGreen / yellow green). Is one enough ? Which one ? any ? Should we add some entries in the pot file until 400 or until 705 ? In any case, it would be easier to use a script to do it. Not sure rgb.txt should be in kdelibs. The problem is the same with timezones : we simply add manually the new entries in pot file. On Friday 20 August 2004 11:59, gerard@delafond.org wrote: > ------- You are receiving this mail because: ------- > You are on the CC list for the bug, or are watching someone who is. > > http://bugs.kde.org/show_bug.cgi?id=87490 > > > > > ------- Additional Comments From gerard delafond org 2004-08-20 11:59 > ------- Thanks for fixing point 5 > ******** > NEW > Point 7: the window is not resizable. Should more comfortable to display a > long list of colors, and more consistent with other KDE windows. (wish) > ******** > About point 6, I don't understand some things. > The actual pot file contains 223 colors > Kcolorchooser contains about 400 > rgb.tx contains about 705 > > I cannot explain why rgb.txt has more entries than Kcolorchooser. I Thought > Kcolorchooser took dynamically its list in rgb.txt > > In rgb.txt, many colors are duplicated (YellowGreen / yellow green). Is one > enough ? Which one ? any ? Colours with spaces are skipped. Colours containing "grey" or "gray" are skipped too. > > Should we add some entries in the pot file until 400 or until 705 ? In any > case, it would be easier to use a script to do it. > > Not sure rgb.txt should be in kdelibs. > > The problem is the same with timezones : we simply add manually the new > entries in pot file. No, it is not the same problem. Currently the colors are created from rgb.txt, however from the version on Scripty's computer, which has seen is not the version of X.org (or the corresponding version of XFree.) Have a nice day! KColorChooser is not in kdelibs (or I would have moved the bug myself.) As the problems in kdelibs, they are the minority in this bug. Have a nice day! On Tuesday 24 August 2004 21:44, Stephan Binner wrote: > ------- You are receiving this mail because: ------- > You are on the CC list for the bug, or are watching someone who is. > > http://bugs.kde.org/show_bug.cgi?id=87490 > binner kde org changed: > > What |Removed |Added > --------------------------------------------------------------------------- >- AssignedTo|bastian kde org |coolo kde org > Product|kde |kdelibs CVS commit by goutte: Use the x.org's rgb.txt as base for the translations CCBUG:87490 M +5 -6 Makefile.am 1.4 M +1 -3 README 1.2 R colors.cpp 1.1 --- kdelibs/kdeui/colors/Makefile.am #1.3:1.4 @@ -1,11 +1,10 @@ -colors: - : > $(srcdir)/colors.cpp + +messages: + : > colors.cpp list=`grep '^[0-9]' /usr/X11R6/lib/X11/rgb.txt | tr ' ' ' ' | sed -e "s#^[0-9]* [0-9]* [0-9]* *##" | grep -v " " | grep -v gray | grep -v grey | LC_ALL=C sort -u` ;\ for i in $$list; do \ - echo "i18n(\"color\", \"$$i\");" | sed -e "s#!# #g" >> $(srcdir)/colors.cpp ;\ + echo "i18n(\"color\", \"$$i\");" | sed -e "s#!# #g" >> colors.cpp ;\ done - -messages: $(XGETTEXT) colors.cpp -o $(podir)/kdelibs_colors.pot + -rm -f colors.cpp -.PHONY: colors --- kdelibs/kdeui/colors/README #1.1:1.2 @@ -1,4 +1,2 @@ -I put colors.cpp here, so that I can have a Makefile.am and ergo -an own pot file for that subdir. But it's not supposed to be compiled -at all +The rgb.txt comes from x.org (xc/programs/rgb/rgb.txt) On Saturday 15 January 2005 21:58, Nicolas Goutte wrote:
> On Saturday 15 January 2005 15:21, G
Is this still relevant to recent KDE version? If not please close the bug. Thanks, Lex. Well... Not really many bugfixes on this program. Translated named colors work now, but still no help, no resizable window... I have no problem with spaces nor with grey names. Thanks see also for possible duplicates of some issues reported here: https://bugs.kde.org/show_bug.cgi?id=275976 https://bugs.kde.org/show_bug.cgi?id=275977 Could someone fix the mess with this report -- one report = one issue. Here it is not the case, so it is best to close it as INVALID, or focus only one ONE issue which is I believe point 6, which is fixed (correct?) thus this report can be closed as FIXED. To summarize the handling of this report: 1° there is no bugreport button Confirmed in 4.7.0, dup of https://bugs.kde.org/show_bug.cgi?id=275977 2° when using bugreport system, this program does not appear in the list Confirmed in 4.7.0, https://bugs.kde.org/show_bug.cgi?id=250467, closed with resolved/invalid 3° the help button leads to nothing No Help button in 4.7.0 4° There is a question mark for "What's this" help, but no help exists anywhere Confirmed in 4.7.0 5° (the worst) the translation mechanism of the named colors broke the ability to choose a color. When you choose a translated color, it is black. Fixed 6° the list of the translatable colors in incomplete Fixed 7° the window is not resizable. Confirmed in 4.7.0, dup of https://bugs.kde.org/show_bug.cgi?id=275976 The bug as it is reported is fixed by comment #5. |