Bug 87048

Summary:	update of fits to histogram does not update properly
Product:	[Applications] kst	Reporter:	Netterfield <netterfield>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Netterfield 2004-08-12 18:10:00 UTC

Version:           0.99-devel (using KDE 3.2 BRANCH >= 20040204, Mandrake Linux Cooker i586 - Cooker)
Compiler:          gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk)
OS:                Linux (i686) release 2.6.2-3mdk

It appears that the updating of plugins takes place before updating of the histograms - so when data is updated, the fit is not.

Additionally, when histogram features are updated, the fit is not updated.

How to reproduce:
Load part a large data set (with time variable statistics) into kst.  Make and plot a histogram .  Fit, (eg) a gaussian to the histogram.  Click Advance one screen.  The histogram is updated, but the fit is not.  Click Advance again: The histogram is updated, and the fit is updated to fit to the previous histogram.  Clicking reload syncs everything up again.

Correct behavior: fits should fit to current data.

Comment 1 Netterfield 2004-08-13 06:00:02 UTC

CVS commit by netterfield: 

fix for Bug 87048: update of fits to histogram does not update properly

update all non-kstvcurve objects before updating curves.

previous behavior was to update plugins before all other objects, which was
probably unintentional.

CCMAIL: 87048-done@bugs.kde.org


  M +4 -4      updatethread.cpp   1.24


--- kdeextragear-2/kst/kst/updatethread.cpp  #1.23:1.24
@@ -22,5 +22,5 @@
 #include <kdebug.h>
 
-#include "kstbasecurve.h"
+#include "kstvcurve.h"
 #include "kstdatacollection.h"
 #include "kstdoc.h"
@@ -205,7 +205,7 @@ bool UpdateThread::doUpdates(bool force,
   {
     // Must make a copy to avoid deadlock
-    KstBaseCurveList cl;
+    KstVCurveList cl;
     KstDataObjectList ncl;
-    kstObjectSplitList<KstDataObject,KstBaseCurve>(KST::dataObjectList, cl, ncl);
+    kstObjectSplitList<KstDataObject,KstVCurve>(KST::dataObjectList, cl, ncl);
 
     // Update all data objects that are not curves
@@ -235,5 +235,5 @@ bool UpdateThread::doUpdates(bool force,
     if (U == KstObject::UPDATE || force) {
       for (i = 0; i < cl.count(); ++i) {
-        KstBaseCurvePtr bcp = cl[i];
+        KstVCurvePtr bcp = cl[i];
         assert(bcp.data());
 #if UPDATEDEBUG > 0