Bug 87011

Summary:	slow redraw of tie boxes
Product:	[Applications] kst	Reporter:	Netterfield <netterfield>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.x
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Netterfield 2004-08-12 05:03:49 UTC

Version:           0.99-devel (using KDE 3.2 BRANCH >= 20040204, Mandrake Linux Cooker i586 - Cooker)
Compiler:          gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk)
OS:                Linux (i686) release 2.6.3-7mdk

If you hit the tied zoom button when you have long plots (eg, 1e6 points) the re-drawing of the tie-boxes is slow, consistent with the plots being re-drawn.

expected behavior: only the tie boxes should be redrawn

Comment 1 Netterfield 2004-08-12 19:40:25 UTC

CVS commit by netterfield: 

Fix for Bug 87011: slow redraw of tie boxes

Tied zoom action does a ->paint(P_PAINT) rather than ->paint(P_DATA)

CCMAIL: 87011-done@bugs.kde.org


  M +3 -3      kst.cpp   1.205
  M +1 -1      kst.h   1.95
  M +4 -4      kstbasecurve.h   1.20
  M +2 -2      kstfitdialog_i.cpp   1.33


--- kdeextragear-2/kst/kst/kst.cpp  #1.204:1.205
@@ -1183,9 +1183,9 @@ void KstApp::tieAll() {
   }
 
-  paintAll();
+  paintAll(P_PAINT);
 }
 
 
-void KstApp::paintAll() {
+void KstApp::paintAll(KstPaintType pt) {
   KMdiIterator<KMdiChildView*> *pIterator = createIterator();
   if (pIterator) {
@@ -1193,5 +1193,5 @@ void KstApp::paintAll() {
       KstViewWindow *pView = dynamic_cast<KstViewWindow*>(pIterator->currentItem());
       if (pView) {
-        pView->view()->paint(P_DATA);
+        pView->view()->paint(pt);
       }
       pIterator->next();

--- kdeextragear-2/kst/kst/kst.h  #1.94:1.95
@@ -116,5 +116,5 @@ class KstApp : public KMdiMainFrm {
     bool dataMode() const;
 
-    void paintAll();
+    void paintAll(KstPaintType = P_DATA);
 
     void EventELOGSubmitEntry(const QString& strMessage);

--- kdeextragear-2/kst/kst/kstbasecurve.h  #1.19:1.20
@@ -92,8 +92,8 @@ public:
   virtual int samplesPerFrame() const { return 1; }
 
-  virtual QString getXVTag() const {return i18n("<None>");}
-  virtual QString getYVTag() const {return i18n("<None>");}
-  virtual QString getYETag() const {return i18n("<None>");}
-  virtual QString getXETag() const {return i18n("<None>");}
+  virtual QString getXVTag() const {return "<None>";}
+  virtual QString getYVTag() const {return "<None>";}
+  virtual QString getYETag() const {return "<None>";}
+  virtual QString getXETag() const {return "<None>";}
   KstPoint Point;
 

--- kdeextragear-2/kst/kst/kstfitdialog_i.cpp  #1.32:1.33
@@ -136,6 +136,6 @@ void KstFitDialogI::show_setCurve(const 
   }
 
-  if ( _xvector==i18n("<None>") ) return;
-  if ( _yvector==i18n("<None>") ) return;
+  if ( _xvector=="<None>" ) return;
+  if ( _yvector=="<None>" ) return;
 
    _tagName->setText(newFitPluginString);